diff options
author | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-10-02 00:17:21 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-10-04 11:36:28 +0200 |
commit | b18545688a6399dbf89b05dae585e15a75b8302a (patch) | |
tree | 2bdcc89c67794ae9a224b91f4f499f8d7e167132 /sfx2 | |
parent | 56c9446f74747214f733757f134cbc9e055ca5e2 (diff) |
clang-tidy modernize-use-equals-default in sfx2
SfxPoolItem has a copy constructor and its copy assignment
operator is deleted. Derived classes have a implicit defined
copy constructor too, if all members are copy constructible.
This patch removes default-able copy constructors and destructors
on such items.
Change-Id: I214dfc016f02617e39a69177aa2233573dfe5f28
Reviewed-on: https://gerrit.libreoffice.org/43039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2')
-rw-r--r-- | sfx2/inc/sorgitm.hxx | 2 | ||||
-rw-r--r-- | sfx2/source/control/minfitem.cxx | 14 | ||||
-rw-r--r-- | sfx2/source/control/sorgitm.cxx | 15 | ||||
-rw-r--r-- | sfx2/source/dialog/tplpitem.cxx | 11 | ||||
-rw-r--r-- | sfx2/source/doc/watermarkitem.cxx | 10 | ||||
-rw-r--r-- | sfx2/source/doc/zoomitem.cxx | 13 |
6 files changed, 0 insertions, 65 deletions
diff --git a/sfx2/inc/sorgitm.hxx b/sfx2/inc/sorgitm.hxx index 521eaa8967cb..f43ac927d84a 100644 --- a/sfx2/inc/sorgitm.hxx +++ b/sfx2/inc/sorgitm.hxx @@ -31,8 +31,6 @@ private: public: static SfxPoolItem* CreateDefault(); SfxScriptOrganizerItem(); - SfxScriptOrganizerItem( const SfxScriptOrganizerItem& ); - virtual ~SfxScriptOrganizerItem() override; virtual SfxPoolItem* Clone( SfxItemPool* pPool = nullptr ) const override; virtual bool operator==( const SfxPoolItem& ) const override; diff --git a/sfx2/source/control/minfitem.cxx b/sfx2/source/control/minfitem.cxx index d7eeb624e454..f7b04998da92 100644 --- a/sfx2/source/control/minfitem.cxx +++ b/sfx2/source/control/minfitem.cxx @@ -38,20 +38,6 @@ SfxMacroInfoItem::SfxMacroInfoItem( { } - -// copy constructor - -SfxMacroInfoItem::SfxMacroInfoItem(const SfxMacroInfoItem& rCopy): - SfxPoolItem(rCopy), - pBasicManager(rCopy.pBasicManager), - aLibName(rCopy.aLibName), - aModuleName(rCopy.aModuleName), - aMethodName(rCopy.aMethodName), - aCommentText(rCopy.aCommentText) -{ -} - - // op == bool SfxMacroInfoItem::operator==( const SfxPoolItem& rCmp) const diff --git a/sfx2/source/control/sorgitm.cxx b/sfx2/source/control/sorgitm.cxx index 1d4395fc6d02..e064fbf5b1e5 100644 --- a/sfx2/source/control/sorgitm.cxx +++ b/sfx2/source/control/sorgitm.cxx @@ -34,21 +34,6 @@ SfxScriptOrganizerItem::SfxScriptOrganizerItem() : } -SfxScriptOrganizerItem::SfxScriptOrganizerItem( const SfxScriptOrganizerItem& rItem ) : - - SfxStringItem( rItem ), - - aLanguage( rItem.aLanguage ) - -{ -} - - -SfxScriptOrganizerItem::~SfxScriptOrganizerItem() -{ -} - - SfxPoolItem* SfxScriptOrganizerItem::Clone( SfxItemPool * ) const { return new SfxScriptOrganizerItem( *this ); diff --git a/sfx2/source/dialog/tplpitem.cxx b/sfx2/source/dialog/tplpitem.cxx index 6f5f77ef1d37..154f7688575b 100644 --- a/sfx2/source/dialog/tplpitem.cxx +++ b/sfx2/source/dialog/tplpitem.cxx @@ -37,17 +37,6 @@ SfxTemplateItem::SfxTemplateItem { } - -// copy constuctor -SfxTemplateItem::SfxTemplateItem( const SfxTemplateItem& rCopy ) : - - SfxFlagItem( rCopy ), - - aStyle( rCopy.aStyle ) -{ -} - - // op == bool SfxTemplateItem::operator==( const SfxPoolItem& rCmp ) const diff --git a/sfx2/source/doc/watermarkitem.cxx b/sfx2/source/doc/watermarkitem.cxx index f54745694557..d6978ff153d9 100644 --- a/sfx2/source/doc/watermarkitem.cxx +++ b/sfx2/source/doc/watermarkitem.cxx @@ -26,16 +26,6 @@ SfxPoolItem* SfxWatermarkItem::CreateDefault() return new SfxWatermarkItem(); } -SfxWatermarkItem::SfxWatermarkItem( const SfxWatermarkItem& rCopy ) -: SfxPoolItem( rCopy ) -, m_aText( rCopy.m_aText ) -, m_aFont( rCopy.m_aFont ) -, m_nAngle( rCopy.m_nAngle ) -, m_nTransparency( rCopy.m_nTransparency ) -, m_nColor( rCopy.m_nColor ) -{ -} - bool SfxWatermarkItem::operator==( const SfxPoolItem& rCmp ) const { return ( SfxPoolItem::operator==( rCmp ) && diff --git a/sfx2/source/doc/zoomitem.cxx b/sfx2/source/doc/zoomitem.cxx index e528175a3187..b86c738e3c5f 100644 --- a/sfx2/source/doc/zoomitem.cxx +++ b/sfx2/source/doc/zoomitem.cxx @@ -47,19 +47,6 @@ SvxZoomItem::SvxZoomItem } -SvxZoomItem::SvxZoomItem( const SvxZoomItem& rOrig ) -: SfxUInt16Item( rOrig.Which(), rOrig.GetValue() ), - nValueSet( rOrig.GetValueSet() ), - eType( rOrig.GetType() ) -{ -} - - -SvxZoomItem::~SvxZoomItem() -{ -} - - SfxPoolItem* SvxZoomItem::Clone( SfxItemPool * /*pPool*/ ) const { return new SvxZoomItem( *this ); |