diff options
| author | Noel Grandin <noel@peralex.com> | 2016-09-29 12:43:17 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-30 06:57:26 +0000 |
| commit | 4d87443bf59c3242d58b56cc1583d73213ae1f2f (patch) | |
| tree | c1f74fc569506299100b5063f14c09e46035a943 /sfx2 | |
| parent | 8e812b87ff7f8c5bf2c6f8858646c55effd2eea3 (diff) | |
loplugin:constantparam
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c
Reviewed-on: https://gerrit.libreoffice.org/29321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2')
| -rw-r--r-- | sfx2/source/appl/newhelp.cxx | 13 | ||||
| -rw-r--r-- | sfx2/source/appl/newhelp.hxx | 5 | ||||
| -rw-r--r-- | sfx2/source/dialog/templdlg.cxx | 4 | ||||
| -rw-r--r-- | sfx2/source/inc/templdgi.hxx | 2 |
4 files changed, 10 insertions, 14 deletions
diff --git a/sfx2/source/appl/newhelp.cxx b/sfx2/source/appl/newhelp.cxx index 9ff07b002498..575ea7174d93 100644 --- a/sfx2/source/appl/newhelp.cxx +++ b/sfx2/source/appl/newhelp.cxx @@ -1342,15 +1342,14 @@ void BookmarksTabPage_Impl::AddBookmarks( const OUString& rTitle, const OUString } OUString SfxHelpWindow_Impl::buildHelpURL(const OUString& sFactory , - const OUString& sContent , - const OUString& sAnchor , - bool bUseQuestionMark) + const OUString& sContent , + const OUString& sAnchor) { OUStringBuffer sHelpURL(256); sHelpURL.append(HELP_URL); sHelpURL.append(sFactory); sHelpURL.append(sContent); - AppendConfigToken(sHelpURL, bUseQuestionMark); + AppendConfigToken(sHelpURL, true/*bUseQuestionMark*/); if (!sAnchor.isEmpty()) sHelpURL.append(sAnchor); return sHelpURL.makeStringAndClear(); @@ -2800,8 +2799,7 @@ void SfxHelpWindow_Impl::ShowStartPage() { OUString sHelpURL = SfxHelpWindow_Impl::buildHelpURL(pIndexWin->GetFactory(), "/start", - OUString(), - true); + OUString()); loadHelpContent(sHelpURL); } @@ -2847,8 +2845,7 @@ IMPL_LINK_NOARG_TYPED(SfxHelpWindow_Impl, OpenHdl, Control*, bool) sHelpURL = SfxHelpWindow_Impl::buildHelpURL(pIndexWin->GetFactory(), aEntry, - aAnchor, - true); + aAnchor); } loadHelpContent(sHelpURL); diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx index a7b82d417050..29efc2113de4 100644 --- a/sfx2/source/appl/newhelp.hxx +++ b/sfx2/source/appl/newhelp.hxx @@ -553,9 +553,8 @@ public: bool bSuccess); static OUString buildHelpURL(const OUString& sFactory , - const OUString& sContent , - const OUString& sAnchor , - bool bUseQuestionMark); + const OUString& sContent , + const OUString& sAnchor); void loadHelpContent(const OUString& sHelpURL , bool bAddToHistory = true); diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx index 66da9470e6e7..cc4119459bf7 100644 --- a/sfx2/source/dialog/templdlg.cxx +++ b/sfx2/source/dialog/templdlg.cxx @@ -675,7 +675,7 @@ namespace SfxTemplate // Constructor -SfxCommonTemplateDialog_Impl::SfxCommonTemplateDialog_Impl( SfxBindings* pB, vcl::Window* pW, bool ) +SfxCommonTemplateDialog_Impl::SfxCommonTemplateDialog_Impl( SfxBindings* pB, vcl::Window* pW ) : pBindings(pB) , pWindow(pW) , pModule(nullptr) @@ -2223,7 +2223,7 @@ static OUString lcl_GetLabel(uno::Any& rAny) } SfxTemplateDialog_Impl::SfxTemplateDialog_Impl(SfxBindings* pB, SfxTemplatePanelControl* pDlgWindow) - : SfxCommonTemplateDialog_Impl(pB, pDlgWindow, true) + : SfxCommonTemplateDialog_Impl(pB, pDlgWindow) , m_pFloat(pDlgWindow) , m_aActionTbL(VclPtrInstance<DropToolBox_Impl>(pDlgWindow, this)) , m_aActionTbR(VclPtrInstance<ToolBox>(pDlgWindow)) diff --git a/sfx2/source/inc/templdgi.hxx b/sfx2/source/inc/templdgi.hxx index 526078cc7fab..f9f55e79207e 100644 --- a/sfx2/source/inc/templdgi.hxx +++ b/sfx2/source/inc/templdgi.hxx @@ -283,7 +283,7 @@ protected: public: - SfxCommonTemplateDialog_Impl( SfxBindings* pB, vcl::Window*, bool ); + SfxCommonTemplateDialog_Impl( SfxBindings* pB, vcl::Window* ); virtual ~SfxCommonTemplateDialog_Impl() override; DECL_LINK_TYPED( MenuSelectHdl, Menu*, bool ); |