summaryrefslogtreecommitdiff
path: root/sfx2
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-09-21 11:44:39 +0100
committerCaolán McNamara <caolanm@redhat.com>2015-09-21 13:57:16 +0100
commit951dbdd13100f92fb3ded20fd8d14ca645c4af37 (patch)
treeca4427650be357cfc9d21f617711b0d3c5a86cec /sfx2
parent4d22eff3c1afc1294785842be163abfa263ef43b (diff)
cppcheck: noExplicitConstructor
Change-Id: I53f9965609c04fd2f0b955fd04de8fc953917344
Diffstat (limited to 'sfx2')
-rw-r--r--sfx2/source/appl/appcfg.cxx2
-rw-r--r--sfx2/source/appl/appdata.cxx5
-rw-r--r--sfx2/source/appl/appdde.cxx4
-rw-r--r--sfx2/source/appl/appserv.cxx2
-rw-r--r--sfx2/source/appl/appuno.cxx4
-rw-r--r--sfx2/source/appl/helpinterceptor.hxx2
-rw-r--r--sfx2/source/appl/imestatuswindow.cxx2
-rw-r--r--sfx2/source/appl/imestatuswindow.hxx2
-rw-r--r--sfx2/source/appl/linksrc.cxx6
-rw-r--r--sfx2/source/appl/newhelp.hxx6
-rw-r--r--sfx2/source/appl/sfxhelp.cxx2
-rw-r--r--sfx2/source/appl/shutdownicon.hxx2
-rw-r--r--sfx2/source/bastyp/fltfnc.cxx14
-rw-r--r--sfx2/source/bastyp/fltlst.cxx2
-rw-r--r--sfx2/source/bastyp/progress.cxx2
-rw-r--r--sfx2/source/control/itemdel.cxx2
-rw-r--r--sfx2/source/control/request.cxx30
17 files changed, 46 insertions, 43 deletions
diff --git a/sfx2/source/appl/appcfg.cxx b/sfx2/source/appl/appcfg.cxx
index 54cd1528c4bb..0b8818ea5be5 100644
--- a/sfx2/source/appl/appcfg.cxx
+++ b/sfx2/source/appl/appcfg.cxx
@@ -89,7 +89,7 @@ class SfxEventAsyncer_Impl : public SfxListener
public:
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) SAL_OVERRIDE;
- SfxEventAsyncer_Impl( const SfxEventHint& rHint );
+ explicit SfxEventAsyncer_Impl(const SfxEventHint& rHint);
virtual ~SfxEventAsyncer_Impl();
DECL_LINK_TYPED( IdleHdl, Idle*, void );
};
diff --git a/sfx2/source/appl/appdata.cxx b/sfx2/source/appl/appdata.cxx
index 4e988409f1c9..ec09c136f6bf 100644
--- a/sfx2/source/appl/appdata.cxx
+++ b/sfx2/source/appl/appdata.cxx
@@ -62,7 +62,10 @@ private:
SfxAppData_Impl& m_rAppData;
public:
- SfxBasicManagerCreationListener( SfxAppData_Impl& _rAppData ) :m_rAppData( _rAppData ) { }
+ explicit SfxBasicManagerCreationListener(SfxAppData_Impl& _rAppData)
+ : m_rAppData(_rAppData)
+ {
+ }
virtual ~SfxBasicManagerCreationListener();
diff --git a/sfx2/source/appl/appdde.cxx b/sfx2/source/appl/appdde.cxx
index 233a2a03d093..00139240937a 100644
--- a/sfx2/source/appl/appdde.cxx
+++ b/sfx2/source/appl/appdde.cxx
@@ -64,7 +64,7 @@ OUString SfxDdeServiceName_Impl( const OUString& sIn )
class ImplDdeService : public DdeService
{
public:
- ImplDdeService( const OUString& rNm )
+ explicit ImplDdeService( const OUString& rNm )
: DdeService( rNm )
{}
virtual bool MakeTopic( const OUString& );
@@ -217,7 +217,7 @@ public:
DdeData aData;
::com::sun::star::uno::Sequence< sal_Int8 > aSeq;
- SfxDdeDocTopic_Impl( SfxObjectShell* pShell )
+ explicit SfxDdeDocTopic_Impl( SfxObjectShell* pShell )
: DdeTopic( pShell->GetTitle(SFX_TITLE_FULLNAME) ), pSh( pShell )
{}
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 1d6798d90a52..69073f9a1601 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -244,7 +244,7 @@ namespace
private:
DECL_LINK_TYPED(ShowHdl, Button*, void);
public:
- LicenseDialog(vcl::Window *pParent=NULL);
+ explicit LicenseDialog(vcl::Window *pParent=NULL);
};
LicenseDialog::LicenseDialog(vcl::Window *pParent)
diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx
index 28f7f0af15e4..c856fedea099 100644
--- a/sfx2/source/appl/appuno.cxx
+++ b/sfx2/source/appl/appuno.cxx
@@ -1716,7 +1716,7 @@ class RequestPackageReparation_Impl : public ::cppu::WeakImplHelper< task::XInte
comphelper::OInteractionDisapprove* m_pDisapprove;
public:
- RequestPackageReparation_Impl( const OUString& aName );
+ explicit RequestPackageReparation_Impl( const OUString& aName );
bool isApproved();
virtual uno::Any SAL_CALL getRequest() throw( uno::RuntimeException, std::exception ) SAL_OVERRIDE;
virtual uno::Sequence< uno::Reference< task::XInteractionContinuation > > SAL_CALL getContinuations()
@@ -1785,7 +1785,7 @@ class NotifyBrokenPackage_Impl : public ::cppu::WeakImplHelper< task::XInteracti
comphelper::OInteractionAbort* m_pAbort;
public:
- NotifyBrokenPackage_Impl( const OUString& aName );
+ explicit NotifyBrokenPackage_Impl(const OUString& rName);
virtual uno::Any SAL_CALL getRequest() throw( uno::RuntimeException, std::exception ) SAL_OVERRIDE;
virtual uno::Sequence< uno::Reference< task::XInteractionContinuation > > SAL_CALL getContinuations()
throw( uno::RuntimeException, std::exception ) SAL_OVERRIDE;
diff --git a/sfx2/source/appl/helpinterceptor.hxx b/sfx2/source/appl/helpinterceptor.hxx
index 8a03f37476f6..2c39307e758c 100644
--- a/sfx2/source/appl/helpinterceptor.hxx
+++ b/sfx2/source/appl/helpinterceptor.hxx
@@ -123,7 +123,7 @@ private:
OUString aFactory;
public:
- HelpListener_Impl( HelpInterceptor_Impl* pInter );
+ explicit HelpListener_Impl( HelpInterceptor_Impl* pInter );
virtual void SAL_CALL statusChanged( const ::com::sun::star::frame::FeatureStateEvent& Event )
throw( ::com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE;
diff --git a/sfx2/source/appl/imestatuswindow.cxx b/sfx2/source/appl/imestatuswindow.cxx
index 84ee426cdbe3..bf031ef343c4 100644
--- a/sfx2/source/appl/imestatuswindow.cxx
+++ b/sfx2/source/appl/imestatuswindow.cxx
@@ -50,7 +50,7 @@ class WeakPropertyChangeListener : public ::cppu::WeakImplHelper<com::sun::star:
com::sun::star::uno::WeakReference<com::sun::star::beans::XPropertyChangeListener> mxOwner;
public:
- WeakPropertyChangeListener(com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener> xOwner)
+ explicit WeakPropertyChangeListener(com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener> xOwner)
: mxOwner(xOwner)
{
}
diff --git a/sfx2/source/appl/imestatuswindow.hxx b/sfx2/source/appl/imestatuswindow.hxx
index 99bd17697c45..6b7a882c3af1 100644
--- a/sfx2/source/appl/imestatuswindow.hxx
+++ b/sfx2/source/appl/imestatuswindow.hxx
@@ -48,7 +48,7 @@ ImeStatusWindow_Impl;
class ImeStatusWindow: private ImeStatusWindow_Impl
{
public:
- ImeStatusWindow( com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext > const& rxContext );
+ explicit ImeStatusWindow( com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext > const& rxContext );
/** Set up VCL according to the configuration.
diff --git a/sfx2/source/appl/linksrc.cxx b/sfx2/source/appl/linksrc.cxx
index f0c9ff47e81c..4847fcb5a522 100644
--- a/sfx2/source/appl/linksrc.cxx
+++ b/sfx2/source/appl/linksrc.cxx
@@ -40,7 +40,7 @@ class SvLinkSourceTimer : public Timer
SvLinkSource * pOwner;
virtual void Invoke() SAL_OVERRIDE;
public:
- SvLinkSourceTimer( SvLinkSource * pOwn );
+ explicit SvLinkSourceTimer( SvLinkSource * pOwn );
};
SvLinkSourceTimer::SvLinkSourceTimer( SvLinkSource * pOwn )
@@ -80,7 +80,7 @@ struct SvLinkSource_Entry_Impl
nAdviseModes( nAdvMode ), bIsDataSink( true )
{}
- SvLinkSource_Entry_Impl( SvBaseLink* pLink )
+ explicit SvLinkSource_Entry_Impl( SvBaseLink* pLink )
: xSink( pLink ), nAdviseModes( 0 ), bIsDataSink( false )
{}
@@ -129,7 +129,7 @@ class SvLinkSource_EntryIter_Impl
const SvLinkSource_Array_Impl& rOrigArr;
sal_uInt16 nPos;
public:
- SvLinkSource_EntryIter_Impl( const SvLinkSource_Array_Impl& rArr );
+ explicit SvLinkSource_EntryIter_Impl( const SvLinkSource_Array_Impl& rArr );
~SvLinkSource_EntryIter_Impl();
SvLinkSource_Entry_Impl* Curr()
{ return nPos < aArr.size() ? aArr[ nPos ] : 0; }
diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index fcbf5ed7f257..72217a1359dc 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -321,7 +321,7 @@ private:
DECL_LINK_TYPED(TabPageDoubleClickHdl, ListBox&, void);
public:
- SfxHelpIndexWindow_Impl( SfxHelpWindow_Impl* pParent );
+ explicit SfxHelpIndexWindow_Impl( SfxHelpWindow_Impl* pParent );
virtual ~SfxHelpIndexWindow_Impl();
virtual void dispose() SAL_OVERRIDE;
@@ -402,7 +402,7 @@ bool SfxHelpIndexWindow_Impl::WasCursorLeftOrRight()
class TextWin_Impl : public DockingWindow
{
public:
- TextWin_Impl( vcl::Window* pParent );
+ explicit TextWin_Impl( vcl::Window* pParent );
virtual bool Notify( NotifyEvent& rNEvt ) SAL_OVERRIDE;
};
@@ -460,7 +460,7 @@ private:
void FindHdl(sfx2::SearchDialog*);
public:
- SfxHelpTextWindow_Impl( SfxHelpWindow_Impl* pParent );
+ explicit SfxHelpTextWindow_Impl( SfxHelpWindow_Impl* pParent );
virtual ~SfxHelpTextWindow_Impl();
virtual void dispose() SAL_OVERRIDE;
diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index 3e5258d82569..c30886b054f4 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -78,7 +78,7 @@ using namespace ::com::sun::star::system;
class NoHelpErrorBox : public MessageDialog
{
public:
- NoHelpErrorBox( vcl::Window* _pParent );
+ explicit NoHelpErrorBox( vcl::Window* _pParent );
virtual void RequestHelp( const HelpEvent& rHEvt ) SAL_OVERRIDE;
};
diff --git a/sfx2/source/appl/shutdownicon.hxx b/sfx2/source/appl/shutdownicon.hxx
index 0950d18427e4..83e566735fde 100644
--- a/sfx2/source/appl/shutdownicon.hxx
+++ b/sfx2/source/appl/shutdownicon.hxx
@@ -80,7 +80,7 @@ class SFX2_DLLPUBLIC ShutdownIcon : public ShutdownIconServiceBase
friend class SfxNotificationListener_Impl;
public:
- ShutdownIcon( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > & rxContext );
+ explicit ShutdownIcon( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > & rxContext );
virtual ~ShutdownIcon();
diff --git a/sfx2/source/bastyp/fltfnc.cxx b/sfx2/source/bastyp/fltfnc.cxx
index 96aaef36d722..8da50c8581c1 100644
--- a/sfx2/source/bastyp/fltfnc.cxx
+++ b/sfx2/source/bastyp/fltfnc.cxx
@@ -153,11 +153,11 @@ public:
OUString aName;
OUString aServiceName;
- SfxFilterContainer_Impl( const OUString& rName )
- : aName( rName )
- {
- aServiceName = SfxObjectShell::GetServiceNameFromFactory( rName );
- }
+ explicit SfxFilterContainer_Impl( const OUString& rName )
+ : aName( rName )
+ {
+ aServiceName = SfxObjectShell::GetServiceNameFromFactory( rName );
+ }
};
#define IMPL_FORWARD_LOOP( aMethod, ArgType, aArg ) \
@@ -263,7 +263,7 @@ public:
void InitForIterating() const;
void Update() const;
- SfxFilterMatcher_Impl(const OUString &rName)
+ explicit SfxFilterMatcher_Impl(const OUString &rName)
: aName(rName)
, pList(0)
{
@@ -290,7 +290,7 @@ namespace
private:
const OUString& mrName;
public:
- hasName(const OUString &rName) : mrName(rName) {}
+ explicit hasName(const OUString &rName) : mrName(rName) {}
bool operator() (const SfxFilterMatcher_Impl& rImpl) const
{
return rImpl.aName == mrName;
diff --git a/sfx2/source/bastyp/fltlst.cxx b/sfx2/source/bastyp/fltlst.cxx
index c6ae1f92e141..a51863e4bcf5 100644
--- a/sfx2/source/bastyp/fltlst.cxx
+++ b/sfx2/source/bastyp/fltlst.cxx
@@ -44,7 +44,7 @@ class SfxRefreshListener : public ::cppu::WeakImplHelper<com::sun::star::util::X
SfxFilterListener *m_pOwner;
public:
- SfxRefreshListener(SfxFilterListener *pOwner)
+ explicit SfxRefreshListener(SfxFilterListener *pOwner)
: m_pOwner(pOwner)
{
}
diff --git a/sfx2/source/bastyp/progress.cxx b/sfx2/source/bastyp/progress.cxx
index 6735a0c27544..c3aacf3c8ff3 100644
--- a/sfx2/source/bastyp/progress.cxx
+++ b/sfx2/source/bastyp/progress.cxx
@@ -66,7 +66,7 @@ struct SfxProgress_Impl
SfxWorkWindow* pWorkWin;
SfxViewFrame* pView;
- SfxProgress_Impl( const OUString& );
+ explicit SfxProgress_Impl( const OUString& );
void Enable_Impl( bool );
};
diff --git a/sfx2/source/control/itemdel.cxx b/sfx2/source/control/itemdel.cxx
index 4808a3784b80..8c9243397bdf 100644
--- a/sfx2/source/control/itemdel.cxx
+++ b/sfx2/source/control/itemdel.cxx
@@ -37,7 +37,7 @@ private:
DECL_LINK_TYPED( Delete, Application*, void );
public:
- SfxItemDisruptor_Impl( SfxPoolItem *pItemToDesrupt );
+ explicit SfxItemDisruptor_Impl(SfxPoolItem *pItemToDesrupt);
void LaunchDeleteOnIdle();
~SfxItemDisruptor_Impl();
};
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index 140db1bcd919..d50ff5068b24 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -70,21 +70,21 @@ struct SfxRequest_Impl: public SfxListener
com::sun::star::uno::Reference< com::sun::star::frame::XDispatchRecorder > xRecorder;
- SfxRequest_Impl( SfxRequest *pOwner )
- : pAnti( pOwner)
- , pPool(0)
- , pRetVal(0)
- , pShell(0)
- , pSlot(0)
- , nModifier(0)
- , bDone(false)
- , bIgnored(false)
- , bCancelled(false)
- , nCallMode( SfxCallMode::SYNCHRON )
- , bAllowRecording( false )
- , pInternalArgs( 0 )
- , pViewFrame(0)
- {}
+ explicit SfxRequest_Impl( SfxRequest *pOwner )
+ : pAnti( pOwner)
+ , pPool(0)
+ , pRetVal(0)
+ , pShell(0)
+ , pSlot(0)
+ , nModifier(0)
+ , bDone(false)
+ , bIgnored(false)
+ , bCancelled(false)
+ , nCallMode( SfxCallMode::SYNCHRON )
+ , bAllowRecording( false )
+ , pInternalArgs( 0 )
+ , pViewFrame(0)
+ {}
virtual ~SfxRequest_Impl() { delete pInternalArgs; }