diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
| commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
| tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /shell/source | |
| parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) | |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'shell/source')
| -rw-r--r-- | shell/source/sessioninstall/SyncDbusSessionHelper.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/shell/source/sessioninstall/SyncDbusSessionHelper.cxx b/shell/source/sessioninstall/SyncDbusSessionHelper.cxx index 3d4e3fa2c7d3..ce13c3377ed2 100644 --- a/shell/source/sessioninstall/SyncDbusSessionHelper.cxx +++ b/shell/source/sessioninstall/SyncDbusSessionHelper.cxx @@ -38,7 +38,7 @@ namespace } GError** getRef() { return &m_pError; } }; - static inline GDBusProxy* lcl_GetPackageKitProxy(const OUString sInterface) + static inline GDBusProxy* lcl_GetPackageKitProxy(const OUString& sInterface) { const OString sFullInterface = OUStringToOString("org.freedesktop.PackageKit." + sInterface, RTL_TEXTENCODING_ASCII_US); GErrorWrapper error(NULL); |