loplugin:virtualdead unused params in OGLTransitionImpl

rename finish to cleanup to avoid conflict with already existing finish
method

Change-Id: I1036eea7e50b20c3c17d769c4094c640939d552d
Reviewed-on: https://gerrit.libreoffice.org/81072
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 9 insertions, 9 deletions

diff --git a/slideshow/source/engine/opengl/TransitionImpl.cxx b/slideshow/source/engine/opengl/TransitionImpl.cxx
index 62127de1d93e..27f1ac28bb9a 100644
--- a/slideshow/source/engine/opengl/TransitionImpl.cxx
+++ b/slideshow/source/engine/opengl/TransitionImpl.cxx
@@ -227,11 +227,11 @@ void OGLTransitionImpl::finish()
     CHECK_GL_ERROR();
 }
 
-void OGLTransitionImpl::prepare( double, double, double, double, double )
+void OGLTransitionImpl::prepare( double, double )
 {
 }
 
-void OGLTransitionImpl::finish( double, double, double, double, double )
+void OGLTransitionImpl::cleanup()
 {
 }
 
@@ -266,7 +266,7 @@ void OGLTransitionImpl::display( double nTime, sal_Int32 glLeavingSlideTex, sal_
 
     CHECK_GL_ERROR();
     glBindVertexArray(m_nVertexArrayObject);
-    prepare( nTime, SlideWidth, SlideHeight, DispWidth, DispHeight );
+    prepare( SlideWidth, SlideHeight );
 
     CHECK_GL_ERROR();
     displaySlides_( nTime, glLeavingSlideTex, glEnteringSlideTex, SlideWidthScale, SlideHeightScale, pContext );
@@ -1878,7 +1878,7 @@ public:
 private:
     virtual GLuint makeShader() const override;
     virtual void prepareTransition( sal_Int32 glLeavingSlideTex, sal_Int32 glEnteringSlideTex, OpenGLContext *pContext ) override;
-    virtual void prepare( double nTime, double SlideWidth, double SlideHeight, double DispWidth, double DispHeight ) override;
+    virtual void prepare( double SlideWidth, double SlideHeight ) override;
 
     glm::vec2 maCenter;
     GLint maSlideRatioLocation = -1;
@@ -1901,7 +1901,7 @@ void RippleTransition::prepareTransition( sal_Int32, sal_Int32, OpenGLContext* )
     CHECK_GL_ERROR();
 }
 
-void RippleTransition::prepare( double /* nTime */, double SlideWidth, double SlideHeight, double /* DispWidth */, double /* DispHeight */ )
+void RippleTransition::prepare( double SlideWidth, double SlideHeight )
 {
     if( maSlideRatioLocation != -1 )
         glUniform1f( maSlideRatioLocation, SlideWidth / SlideHeight );
@@ -1975,7 +1975,7 @@ public:
 private:
     virtual GLuint makeShader() const override;
     virtual void prepareTransition( sal_Int32 glLeavingSlideTex, sal_Int32 glEnteringSlideTex, OpenGLContext *pContext ) override;
-    virtual void finish( double nTime, double SlideWidth, double SlideHeight, double DispWidth, double DispHeight ) override;
+    virtual void cleanup() override;
 
     GLuint maBuffer = 0;
 };
@@ -2025,7 +2025,7 @@ void GlitterTransition::prepareTransition( sal_Int32 glLeavingSlideTex, sal_Int3
     glBindBuffer(GL_ARRAY_BUFFER, 0);
 }
 
-void GlitterTransition::finish( double, double, double, double, double )
+void GlitterTransition::cleanup()
 {
     CHECK_GL_ERROR();
     glDeleteBuffers(1, &maBuffer);
diff --git a/slideshow/source/engine/opengl/TransitionImpl.hxx b/slideshow/source/engine/opengl/TransitionImpl.hxx
index d2f78c6eb3d9..d0313236d8b4 100644
--- a/slideshow/source/engine/opengl/TransitionImpl.hxx
+++ b/slideshow/source/engine/opengl/TransitionImpl.hxx
@@ -171,13 +171,13 @@ private:
       *
       * Default implementation does nothing.
       */
-    virtual void prepare( double nTime, double SlideWidth, double SlideHeight, double DispWidth, double DispHeight );
+    virtual void prepare( double SlideWidth, double SlideHeight );
 
     /** This function is called in display method to prepare the slides, scene, etc.
       *
       * Default implementation does nothing.
       */
-    virtual void finish( double nTime, double SlideWidth, double SlideHeight, double DispWidth, double DispHeight );
+    virtual void cleanup();
 
     /** This function is called after glx context is ready to let the transition prepare GL related things, like GLSL program.
       *