teach passstuffbyref plugin to check for..

unnecessarily passing primitives by const ref.

Suggested by Tor Lillqvist

Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

3 files changed, 7 insertions, 7 deletions

diff --git a/slideshow/source/engine/eventmultiplexer.cxx b/slideshow/source/engine/eventmultiplexer.cxx
index b71e71c71e16..96b86bf2218d 100644
--- a/slideshow/source/engine/eventmultiplexer.cxx
+++ b/slideshow/source/engine/eventmultiplexer.cxx
@@ -1017,11 +1017,11 @@ void EventMultiplexer::notifySwitchEraserMode(){
 }
 
 //adding erasing all ink features with UserPaintOverlay
-void EventMultiplexer::notifyEraseAllInk( bool const& rEraseAllInk )
+void EventMultiplexer::notifyEraseAllInk( bool bEraseAllInk )
 {
     mpImpl->maUserPaintEventHandlers.applyAll(
-        [&rEraseAllInk]( const UserPaintEventHandlerSharedPtr& pHandler )
-        { return pHandler->eraseAllInkChanged( rEraseAllInk ); } );
+        [&bEraseAllInk]( const UserPaintEventHandlerSharedPtr& pHandler )
+        { return pHandler->eraseAllInkChanged( bEraseAllInk ); } );
 }
 
 //adding erasing features with UserPaintOverlay
diff --git a/slideshow/source/engine/slide/userpaintoverlay.cxx b/slideshow/source/engine/slide/userpaintoverlay.cxx
index 68a3a4ea96a8..3e720c3b9322 100644
--- a/slideshow/source/engine/slide/userpaintoverlay.cxx
+++ b/slideshow/source/engine/slide/userpaintoverlay.cxx
@@ -161,9 +161,9 @@ namespace slideshow
                     }
             }
 
-            bool eraseAllInkChanged( bool const& rEraseAllInk ) override
+            bool eraseAllInkChanged( bool bEraseAllInk ) override
             {
-                this->mbIsEraseAllModeActivated= rEraseAllInk;
+                this->mbIsEraseAllModeActivated = bEraseAllInk;
                 // if the erase all mode is activated it will remove all ink from slide,
                 // therefore destroy all the polygons stored
                 if(mbIsEraseAllModeActivated)
diff --git a/slideshow/source/inc/eventmultiplexer.hxx b/slideshow/source/inc/eventmultiplexer.hxx
index b1a4a0054523..5a34fc08bcd0 100644
--- a/slideshow/source/inc/eventmultiplexer.hxx
+++ b/slideshow/source/inc/eventmultiplexer.hxx
@@ -111,7 +111,7 @@ public:
     virtual ~UserPaintEventHandler() {}
     virtual bool colorChanged( RGBColor const& rUserColor ) = 0;
     virtual bool widthChanged( double nUserStrokeWidth ) = 0;
-    virtual bool eraseAllInkChanged(bool const& rEraseAllInk) =0;
+    virtual bool eraseAllInkChanged(bool bEraseAllInk) =0;
     virtual bool eraseInkWidthChanged(sal_Int32 rEraseInkSize) =0;
     virtual bool switchEraserMode() = 0;
     virtual bool switchPenMode() = 0;
@@ -529,7 +529,7 @@ public:
      enabled. User paint denotes the feature to draw colored lines
      on top of the slide content.
      */
-    void notifyEraseAllInk( bool const& rEraseAllInk );
+    void notifyEraseAllInk( bool bEraseAllInk );
     void notifySwitchPenMode();
     void notifySwitchEraserMode();
     void notifyEraseInkWidth( sal_Int32 rEraseInkSize );