diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-03-09 14:28:47 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-03-10 11:34:00 +0000 |
| commit | 50b68c341f2543c4d841fce4d4b3e080f4491e1d (patch) | |
| tree | ddeece0ddf664cdd258ef6c19919c5644d9945b2 /slideshow | |
| parent | 8ceb85cafb0af066c5b8466da61a46eef2779dc6 (diff) | |
improve loplugin:unnecessarylocking
to find more locking we can remove
Change-Id: Ief7bc5ec2a1ff31f22a0ad366910b7fcc4725818
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148599
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'slideshow')
| -rw-r--r-- | slideshow/source/engine/slideshowimpl.cxx | 4 | ||||
| -rw-r--r-- | slideshow/source/engine/slideview.cxx | 4 |
2 files changed, 0 insertions, 8 deletions
diff --git a/slideshow/source/engine/slideshowimpl.cxx b/slideshow/source/engine/slideshowimpl.cxx index 923ea26d0bc0..9109bb6bb2e0 100644 --- a/slideshow/source/engine/slideshowimpl.cxx +++ b/slideshow/source/engine/slideshowimpl.cxx @@ -1268,8 +1268,6 @@ void SlideShowImpl::rewindEffectToPreviousSlide() sal_Bool SlideShowImpl::startShapeActivity( uno::Reference<drawing::XShape> const& /*xShape*/ ) { - osl::MutexGuard const guard( m_aMutex ); - // precondition: must only be called from the main thread! DBG_TESTSOLARMUTEX(); @@ -1281,8 +1279,6 @@ sal_Bool SlideShowImpl::startShapeActivity( sal_Bool SlideShowImpl::stopShapeActivity( uno::Reference<drawing::XShape> const& /*xShape*/ ) { - osl::MutexGuard const guard( m_aMutex ); - // precondition: must only be called from the main thread! DBG_TESTSOLARMUTEX(); diff --git a/slideshow/source/engine/slideview.cxx b/slideshow/source/engine/slideview.cxx index 26c4e0f971bb..8b527630bca3 100644 --- a/slideshow/source/engine/slideview.cxx +++ b/slideshow/source/engine/slideview.cxx @@ -934,8 +934,6 @@ cppcanvas::CustomSpriteSharedPtr SlideView::createSprite( void SlideView::setPriority( const basegfx::B1DRange& /*rRange*/ ) { - osl::MutexGuard aGuard( m_aMutex ); - OSL_FAIL( "SlideView::setPriority() is a NOOP for slide view - " "content will always be shown in the background" ); } @@ -976,8 +974,6 @@ void SlideView::setClip( const basegfx::B2DPolyPolygon& rClip ) bool SlideView::resize( const ::basegfx::B2DRange& /*rArea*/ ) { - osl::MutexGuard aGuard( m_aMutex ); - OSL_FAIL( "SlideView::resize(): ignored for the View, can't change size " "effectively, anyway" ); |