summaryrefslogtreecommitdiff
path: root/solenv
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2020-08-02 18:01:28 +0100
committerCaolán McNamara <caolanm@redhat.com>2020-08-02 22:07:00 +0200
commitf716fd1580bcc6042afaab9beba24ca6cbcb1c73 (patch)
tree8feda14b5639ce70c9124e6128c5f4be533ff5bc /solenv
parent36f5265b038b610c61ebc459465c5c58b1d9dc28 (diff)
tdf#135369 on removing an image link, ensure the linked to image is in the list
If we removed something that is a link to a real file from our list of images to pack, but that real image is not in the list of images to pack, add it in instead so the real image does get packed Change-Id: I71bcbdf872a59194a1d94f287dda8fc27e4a6464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'solenv')
-rw-r--r--solenv/bin/pack_images.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/solenv/bin/pack_images.py b/solenv/bin/pack_images.py
index 5d368658961f..5ccc194e6307 100644
--- a/solenv/bin/pack_images.py
+++ b/solenv/bin/pack_images.py
@@ -342,7 +342,13 @@ def remove_links_from_zip_list(zip_list, links):
for link in links.keys():
if link in zip_list:
+ module = zip_list[link]
del zip_list[link]
+ # tdf#135369 if we removed something that is a link to a real file
+ # from our list of images to pack, but that real image is not in
+ # the list of images to pack, add it in instead now
+ if links[link] not in zip_list:
+ zip_list[links[link]] = module
LOGGER.debug("Cleaned zip list:\n%s", "\n".join(zip_list))