diff options
| author | Collabora <l.lunak@collabora.com> | 2021-07-15 12:18:49 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2021-07-23 10:32:08 +0200 |
| commit | 2d04d7cc559445d8c1559af6af6d981d9f682db4 (patch) | |
| tree | 8f9ed81590800f772f162f93473c654f4eefb468 /solenv | |
| parent | a470d97f2ddcb3607ae9d1df871a59f04d823564 (diff) | |
do not use "using namespace std" in headers
It's a bad style, doing that in headers can affect many source files
(especially with PCH used).
Change-Id: Ic9091a1d018e74606c9fa95df71a55faaa93d4ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119011
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/gcc-wrappers/g++.cxx | 2 | ||||
| -rw-r--r-- | solenv/gcc-wrappers/gcc.cxx | 2 | ||||
| -rw-r--r-- | solenv/gcc-wrappers/wrapper.cxx | 2 | ||||
| -rw-r--r-- | solenv/gcc-wrappers/wrapper.hxx | 8 |
4 files changed, 9 insertions, 5 deletions
diff --git a/solenv/gcc-wrappers/g++.cxx b/solenv/gcc-wrappers/g++.cxx index 2f99d4606ac7..ae7dcb6be796 100644 --- a/solenv/gcc-wrappers/g++.cxx +++ b/solenv/gcc-wrappers/g++.cxx @@ -9,6 +9,8 @@ #include "wrapper.hxx" +using namespace std; + int main(int argc, char* argv[]) { vector<string> rawargs(argv + 1, argv + argc); diff --git a/solenv/gcc-wrappers/gcc.cxx b/solenv/gcc-wrappers/gcc.cxx index 8accb8216a11..a51d64ff39fa 100644 --- a/solenv/gcc-wrappers/gcc.cxx +++ b/solenv/gcc-wrappers/gcc.cxx @@ -9,6 +9,8 @@ #include "wrapper.hxx" +using namespace std; + int main(int argc, char* argv[]) { vector<string> rawargs(argv + 1, argv + argc); diff --git a/solenv/gcc-wrappers/wrapper.cxx b/solenv/gcc-wrappers/wrapper.cxx index 22a1b9488212..a03b1dddee90 100644 --- a/solenv/gcc-wrappers/wrapper.cxx +++ b/solenv/gcc-wrappers/wrapper.cxx @@ -15,6 +15,8 @@ #define BUFLEN 2048 +using namespace std; + string getexe(string exename, bool maybeempty) { char* cmdbuf; size_t cmdlen; diff --git a/solenv/gcc-wrappers/wrapper.hxx b/solenv/gcc-wrappers/wrapper.hxx index 208d9b82c449..e4a4bb3bbeb5 100644 --- a/solenv/gcc-wrappers/wrapper.hxx +++ b/solenv/gcc-wrappers/wrapper.hxx @@ -14,15 +14,13 @@ #include <iostream> #include <vector> -using namespace std; - -string getexe(string exename, bool maybeempty = false); +std::string getexe(std::string exename, bool maybeempty = false); void setupccenv(); -string processccargs(vector<string> rawargs, string& env_prefix, bool& verbose); +std::string processccargs(std::vector<std::string> rawargs, std::string& env_prefix, bool& verbose); -int startprocess(string command, string args, bool verbose); +int startprocess(std::string command, std::string args, bool verbose); #endif // INCLUDED_SOLENV_GCC_WRAPPERS_WRAPPER_HXX |