summaryrefslogtreecommitdiff
path: root/solenv
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2018-03-16 14:49:13 +0100
committerStephan Bergmann <sbergman@redhat.com>2018-03-20 09:56:59 +0100
commit049d94a5fcfa55039a166164648ecdb28fe7291f (patch)
tree003831c3a69c6cf84190c68c92fb2bfc812961cf /solenv
parent38c153c121fc05c49fa9bb02f3a4edf54a3ddeb1 (diff)
Make failure to create symlink a fatal error
...see commit message of f07e2496963baf8f7c0fecc79e7a420544075d98 "sdk/lib dir missing from Linux installation sets" Change-Id: Idb0f3437c27c867bc628fd3084f2a54c47beef17 Reviewed-on: https://gerrit.libreoffice.org/51428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'solenv')
-rw-r--r--solenv/bin/modules/installer/simplepackage.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/solenv/bin/modules/installer/simplepackage.pm b/solenv/bin/modules/installer/simplepackage.pm
index 23b9983a6eb5..30f41e43f6ff 100644
--- a/solenv/bin/modules/installer/simplepackage.pm
+++ b/solenv/bin/modules/installer/simplepackage.pm
@@ -652,10 +652,10 @@ sub create_simple_package
my $target = $onelink->{'Target'};
my $destination = $subfolderdir . $installer::globals::separator . $onelink->{'destination'};
- my $localcall = "ln -sf \'$target\' \'$destination\' \>\/dev\/null 2\>\&1";
- system($localcall);
+ my @localcall = ('ln', '-sf', $target, $destination);
+ system(@localcall) == 0 or die "system @localcall failed: $?";
- $infoline = "Creating Unix link: \"ln -sf $target $destination\"\n";
+ $infoline = "Creating Unix link: \"@localcall\"\n";
push(@installer::globals::logfileinfo, $infoline);
}