gla11y: Enable label-for/labelled-by pairing warnings

Change-Id: Icecc1cf3d7ec5c217e705640f1c4a049b75a6778
Reviewed-on: https://gerrit.libreoffice.org/52405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

7 files changed, 60 insertions, 2 deletions

diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk
index 4923dd26e431..aec1efb33316 100644
--- a/solenv/gbuild/UIConfig.mk
+++ b/solenv/gbuild/UIConfig.mk
@@ -161,8 +161,8 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type orphan-label
 
 # These are definite errors
 gb_UIConfig_gla11y_PARAMETERS += --enable-type undeclared-target
-#gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for
-#gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by
+gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for
+gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by
 
 # These are often buttons with only an image
 #gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index 598c7a600ae3..8f00b81c4cf2 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -6,3 +6,7 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='angleft'] orphan-label
 cui/uiconfig/ui/hatchpage.ui://GtkScale[@id='angleslider'] no-labelled-by
 cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linetypeft'] orphan-label
 cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label
+cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinPageNumber'] missing-label-for
+cui/uiconfig/ui/textflowpage.ui://GtkComboBox[@id='comboPageStyle'] missing-label-for
+cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinOrphan'] missing-label-for
+cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinWidow'] missing-label-for
diff --git a/solenv/sanitizers/ui/filter.suppr b/solenv/sanitizers/ui/filter.suppr
new file mode 100644
index 000000000000..5cff1cecf634
--- /dev/null
+++ b/solenv/sanitizers/ui/filter.suppr
@@ -0,0 +1 @@
+filter/uiconfig/ui/pdfgeneralpage.ui://GtkCheckButton[@id='reduceresolution'] missing-labelled-by
diff --git a/solenv/sanitizers/ui/modules/scalc.suppr b/solenv/sanitizers/ui/modules/scalc.suppr
new file mode 100644
index 000000000000..83ffb6cae818
--- /dev/null
+++ b/solenv/sanitizers/ui/modules/scalc.suppr
@@ -0,0 +1,25 @@
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='connect1'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field1'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field2'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field3'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond1'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond2'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond3'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val1'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val2'] missing-label-for
+sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val3'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect1'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect2'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field1'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field2'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field3'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='cond1'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='cond2'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='cond3'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val1'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val2'] missing-label-for
+sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val3'] missing-label-for
+sc/uiconfig/scalc/ui/selectsource.ui://GtkRadioButton[@id='namedrange'] missing-labelled-by
+sc/uiconfig/scalc/ui/selectsource.ui://GtkComboBoxText[@id='rangelb'] missing-labelled-by
+sc/uiconfig/scalc/ui/sidebaralignment.ui://GtkSpinButton[@id='leftindent:0pt'] missing-label-for
+sc/uiconfig/scalc/ui/sidebaralignment.ui://VclComboBoxNumeric[@id='orientationdegrees:0degrees'] missing-label-for
diff --git a/solenv/sanitizers/ui/modules/simpress.suppr b/solenv/sanitizers/ui/modules/simpress.suppr
new file mode 100644
index 000000000000..c2c8874d28da
--- /dev/null
+++ b/solenv/sanitizers/ui/modules/simpress.suppr
@@ -0,0 +1,3 @@
+sd/uiconfig/simpress/ui/headerfootertab.ui://GtkRadioButton[@id='rb_auto'] missing-label-for
+sd/uiconfig/simpress/ui/prntopts.ui://GtkCheckButton[@id='frontcb'] missing-label-for
+sd/uiconfig/simpress/ui/prntopts.ui://GtkCheckButton[@id='backcb'] missing-label-for
diff --git a/solenv/sanitizers/ui/modules/swriter.suppr b/solenv/sanitizers/ui/modules/swriter.suppr
new file mode 100644
index 000000000000..7b6e82b77479
--- /dev/null
+++ b/solenv/sanitizers/ui/modules/swriter.suppr
@@ -0,0 +1,8 @@
+sw/uiconfig/swriter/ui/frmtypepage.ui://GtkCheckButton[@id='relwidth'] missing-labelled-by
+sw/uiconfig/swriter/ui/frmtypepage.ui://GtkCheckButton[@id='relheight'] missing-labelled-by
+sw/uiconfig/swriter/ui/insertbreak.ui://GtkSpinButton[@id='pagenumsb'] missing-label-for
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkComboBoxText[@id='parastyle'] missing-label-for
+sw/uiconfig/swriter/ui/numparapage.ui://GtkCheckButton[@id='checkCB_NUMBER_NEW_START'] missing-labelled-by
+sw/uiconfig/swriter/ui/tocindexpage.ui://GtkButton[@id='styles'] missing-label-for
+sw/uiconfig/swriter/ui/tabletextflowpage.ui://GtkSpinButton[@id='pagenonf'] missing-label-for
+sw/uiconfig/swriter/ui/titlepage.ui://GtkSpinButton[@id='NF_PAGE_START'] missing-label-for
diff --git a/solenv/sanitizers/ui/svx.suppr b/solenv/sanitizers/ui/svx.suppr
index b9babb1171ab..c10ad8d7092c 100644
--- a/solenv/sanitizers/ui/svx.suppr
+++ b/solenv/sanitizers/ui/svx.suppr
@@ -5,8 +5,25 @@ svx/uiconfig/ui/mediaplayback.ui://GtkLabel[@id='label2'] orphan-label
 svx/uiconfig/ui/mediaplayback.ui://GtkLabel[@id='label3'] orphan-label
 svx/uiconfig/ui/mediaplayback.ui://GtkScale[@id='timeslider'] no-labelled-by
 svx/uiconfig/ui/mediaplayback.ui://GtkScale[@id='volumeslider'] no-labelled-by
+svx/uiconfig/ui/redlinefilterpage.ui://GtkCheckButton[@id='comment'] missing-labelled-by
+svx/uiconfig/ui/redlinefilterpage.ui://GtkComboBoxText[@id='actionlist'] missing-label-for
+svx/uiconfig/ui/redlinefilterpage.ui://GtkComboBoxText[@id='authorlist'] missing-label-for
+svx/uiconfig/ui/redlinefilterpage.ui://GtkEntry[@id='rangeedit'] missing-label-for
+svx/uiconfig/ui/redlinefilterpage.ui://GtkComboBoxText[@id='datecond'] missing-label-for
+svx/uiconfig/ui/sidebararea.ui://svxlo-SvxFillAttrBox[@id='fillattr'] missing-label-for
+svx/uiconfig/ui/sidebararea.ui://svxlo-SvxFillTypeBox[@id='fillstyle'] missing-label-for
 svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='angle'] orphan-label
 svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='distance'] orphan-label
 svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='transparency_label'] orphan-label
 svx/uiconfig/ui/sidebarshadow.ui://GtkScale[@id='transparency_slider'] no-labelled-by
 svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='color'] orphan-label
+svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='setbrightness:%'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='setcontrast:%'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkComboBoxText[@id='setcolormode'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='settransparency:%'] missing-label-for
+svx/uiconfig/ui/sidebarline.ui://GtkSpinButton[@id='linetransparency:0%'] missing-label-for
+svx/uiconfig/ui/sidebarpossize.ui://GtkSpinButton[@id='horizontalpos:0in'] missing-label-for
+svx/uiconfig/ui/sidebarpossize.ui://GtkSpinButton[@id='verticalpos:0in'] missing-label-for
+svx/uiconfig/ui/sidebarpossize.ui://GtkSpinButton[@id='selectwidth:0in'] missing-label-for
+svx/uiconfig/ui/sidebarpossize.ui://GtkSpinButton[@id='selectheight:0in'] missing-label-for
+svx/uiconfig/ui/sidebarpossize.ui://svxlo-SidebarDialControl[@id='orientationcontrol'] missing-label-for