diff options
| author | Justin Luth <justin.luth@collabora.com> | 2021-03-16 10:16:02 +0200 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.com> | 2021-03-17 09:28:46 +0100 |
| commit | b6850b9827a13b8f8d9b9749a982e128b7e0e867 (patch) | |
| tree | 6db2184c97059855abf2d9e7d40a11b30c079026 /solenv | |
| parent | 719ca339f54698482087e17e2271e18ec10de142 (diff) | |
... can cause loops
from LO 3.5 commit 36c905d8c2874f6f984d5fbbc07784ec20c43524
The PostFormat for Center and Decimal tabstops is critical
since the space they take up is unknown until the following
text is evaluated.
The search position in these two cases is invalid
until the text position is calculated by PostFormat.
PostFormat normally returns FALSE, so in almost all
cases the rest of NewTabPortion completes. The function only
returned early if the start of the tabstop was beyond
the right margin. I assume the original intent was to
avoid potentially unnecessary processing.
However, returning early can cause looping,
which the LO 3.5 commit "fixed" by removing everything.
Well, just remove the early return and both problems are solved.
Change-Id: I4afc4cce8249f90097bc1f263df1a39bc219098d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112559
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/clang-format/excludelist | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist index bd07aeebc58f..9aacb7ba1b77 100644 --- a/solenv/clang-format/excludelist +++ b/solenv/clang-format/excludelist @@ -12320,6 +12320,7 @@ sw/qa/extras/globalfilter/globalfilter.cxx sw/qa/extras/htmlimport/htmlimport.cxx sw/qa/extras/mailmerge/mailmerge.cxx sw/qa/extras/odfexport/odfexport.cxx +sw/qa/extras/odfexport/odfexport2.cxx sw/qa/extras/odfimport/odfimport.cxx sw/qa/extras/ooxmlexport/ooxmlexport.cxx sw/qa/extras/ooxmlexport/ooxmlexport10.cxx |