diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-05-17 17:40:06 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-09-20 13:31:50 +0200 |
| commit | 28e028680b3c0551db3a9b71c8fe6b66aac2433b (patch) | |
| tree | 17688b5602e93c550775696a3c0dc0cdc090ddfa /solenv | |
| parent | 9b231713790c6e94eb64c3fc108ce99ebd2b90af (diff) | |
Remove legacy NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY support
...for ASan/UBSan builds using Clang older than current trunk twoards Clang 9,
as announced at
<https://lists.freedesktop.org/archives/libreoffice/2019-May/082654.html> "Re:
[Libreoffice-commits] core.git: The -fvisibility-ms-compat hack is no longer
needed for UBSan on Linux...". (And drop the no longer needed
solenv/sanitizers/asan-suppressions, which people might still reference from
their ASAN_OPTIONS.)
Change-Id: Iedc0c5955366d2cbe7dc847990e2b1576750e85b
Reviewed-on: https://gerrit.libreoffice.org/72493
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/gbuild/platform/com_GCC_defs.mk | 4 | ||||
| -rw-r--r-- | solenv/gbuild/platform/unxgcc.mk | 3 | ||||
| -rw-r--r-- | solenv/sanitizers/asan-suppressions | 31 |
3 files changed, 0 insertions, 38 deletions
diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index a17db5a82e84..485bd6e99d3d 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -126,12 +126,8 @@ endif # If CC or CXX already include -fvisibility=hidden, don't duplicate it ifeq (,$(filter -fvisibility=hidden,$(CC))) -ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE) -gb_VISIBILITY_FLAGS := -fvisibility-ms-compat -else gb_VISIBILITY_FLAGS := -fvisibility=hidden endif -endif gb_VISIBILITY_FLAGS_CXX := -fvisibility-inlines-hidden gb_CXXFLAGS_COMMON += $(gb_VISIBILITY_FLAGS_CXX) diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index df5eb7ca94c6..8854aab6c425 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -84,9 +84,6 @@ endif ifneq ($(HAVE_LD_BSYMBOLIC_FUNCTIONS),) gb_LinkTarget_LDFLAGS += -Wl,-Bsymbolic-functions -ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE) -gb_LinkTarget_LDFLAGS += -Wl,--dynamic-list-cpp-typeinfo -endif endif gb_LINKEROPTFLAGS := -Wl,-O1 diff --git a/solenv/sanitizers/asan-suppressions b/solenv/sanitizers/asan-suppressions deleted file mode 100644 index dd2c4f12ce61..000000000000 --- a/solenv/sanitizers/asan-suppressions +++ /dev/null @@ -1,31 +0,0 @@ -# [CUT] cppcanvas_emfplus -# ================================================================= -# ==32735==ERROR: AddressSanitizer: odr-violation (0x7f8f717e28a0): -# [1] size=40 'vtable for graphite2::CachedFace' /home/sbergman/lo/core/workdir/UnpackedTarball/graphite/src/CachedFace.cpp -# [2] size=40 'vtable for graphite2::CachedFace' /home/sbergman/lo/core/workdir/UnpackedTarball/graphite/src/CachedFace.cpp -# These globals were registered at these points: -# [1]: -# #0 in __asan_register_globals.part.13 at /home/sbergman/github.com/llvm-project/llvm-project-20170507/compiler-rt/lib/asan/asan_globals.cc:359:3 (workdir/LinkTarget/Executable/cppunittester +0x446ff0) -# #1 in asan.module_ctor at <null> (instdir/program/libvclplug_gtk3lo.so +0xed96cb) -# -# [2]: -# #0 in __asan_register_globals.part.13 at /home/sbergman/github.com/llvm-project/llvm-project-20170507/compiler-rt/lib/asan/asan_globals.cc:359:3 (workdir/LinkTarget/Executable/cppunittester +0x446ff0) -# #1 in asan.module_ctor at <null> (instdir/program/libvcllo.so +0x6e169cb) -# -# ...and more (partly because -fvisibility-ms-compat (and "-XClang -ftype-visibility -XClang -# default", which it internally uses) also gives _ZTV* symbols default visibility): -odr_violation:^_ZTIN9graphite210CachedCmapE$ -odr_violation:^_ZTSN9graphite210CachedCmapE$ -odr_violation:^_ZTVN9graphite210CachedCmapE$ -odr_violation:^_ZTSN9graphite210CachedFaceE$ -odr_violation:^_ZTIN9graphite210CachedFaceE$ -odr_violation:^_ZTVN9graphite210CachedFaceE$ -odr_violation:^_ZTIN9graphite210DirectCmapE$ -odr_violation:^_ZTSN9graphite210DirectCmapE$ -odr_violation:^_ZTVN9graphite210DirectCmapE$ -odr_violation:^_ZTSN9graphite24FaceE$ -odr_violation:^_ZTIN9graphite24FaceE$ -odr_violation:^_ZTVN9graphite24FaceE$ -odr_violation:^_ZTSN9graphite24FontE$ -odr_violation:^_ZTIN9graphite24FontE$ -odr_violation:^_ZTVN9graphite24FontE$ |