diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-20 08:11:58 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-20 07:34:27 +0000 |
| commit | f255c3e96e25a43a4724d80287554d892d7ffd70 (patch) | |
| tree | d254a6911479fcea98ec5c04569951219bb68501 /solenv | |
| parent | 60b6b1eae563c727160724a8671844bf8136f5d5 (diff) | |
[API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always true
* GCC documents -fvisibility at least as far back as the GCC 4.0 online
documentation at
<https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>.
* For external code, odk/settings/settings.mk unconditionally set
HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112
Reviewed-on: https://gerrit.libreoffice.org/29073
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/gbuild/platform/com_GCC_defs.mk | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index 5f00cf433f1e..45b077fe7004 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -101,22 +101,18 @@ gb_CXXFLAGS_COMMON += -Wimplicit-fallthrough endif -ifeq ($(HAVE_GCC_VISIBILITY_FEATURE),TRUE) -gb_VISIBILITY_FLAGS := -DHAVE_GCC_VISIBILITY_FEATURE # If CC or CXX already include -fvisibility=hidden, don't duplicate it ifeq (,$(filter -fvisibility=hidden,$(CC))) -gb__visibility_hidden := -fvisibility=hidden +gb_VISIBILITY_FLAGS := -fvisibility=hidden ifeq ($(COM_IS_CLANG),TRUE) ifneq ($(filter -fsanitize=%,$(CC)),) -gb__visibility_hidden := -fvisibility-ms-compat +gb_VISIBILITY_FLAGS := -fvisibility-ms-compat endif endif -gb_VISIBILITY_FLAGS += $(gb__visibility_hidden) endif ifneq ($(HAVE_GCC_VISIBILITY_BROKEN),TRUE) gb_VISIBILITY_FLAGS_CXX := -fvisibility-inlines-hidden endif -endif gb_CXXFLAGS_COMMON += $(gb_VISIBILITY_FLAGS_CXX) ifeq ($(HAVE_GCC_STACK_PROTECTOR_STRONG),TRUE) |