diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2023-10-06 09:50:54 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2023-10-07 22:34:09 +0200 |
| commit | 7ef3d937415185ef66e32dd3043783eddcd03db5 (patch) | |
| tree | cde190b7a568ed038ca513cb165304bd574e7224 /solenv | |
| parent | 2a92fe4c529f438421fad14cfbb1a76a45902fd9 (diff) | |
loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr literals
This is a first cut at rewriting uses of OUString constructed from u"..." as
u"..."_ustr. It covers the same changes as
<https://gerrit.libreoffice.org/c/core/+/155412/6/> "WIP: Delete OUString UTF-16
string literal ctor/assignment op", but does so with automatic rewriting (see
e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 "loplugin:ostr: automatic rewrite",
plus a handful of 002b0a9d5793e07609f953b9961b04bcab7a7e3f "loplugin:ostr:
manual modifications" where automatic rewriting wasn't set up to handle macro
bodies).
The compilation-time impact of all those changes appears to be negligible: For
some Windows build of mine, just touching the files that would be affected by
002b0a9d5793e07609f953b9961b04bcab7a7e3f and
e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 (but without actually applying those
changes yet) and doing `time /opt/lo/bin/make -O check screenshot PKGFORMAT=
gb_SUPPRESS_TESTS=x`, three times in a row reported sample real times of
21m15.438s 23m17.840s 23m41.529s
and repeating all that with the two changes actually applied reported sample
real times of
22m43.547s 21m42.687s 23m1.813s
The plugin itself is already prepared to do further rewrites (see the TODOs),
which will be done in follow-up commits.
Change-Id: I408ecf056dce1b9da683d7c377b8d9058df1558d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157676
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/CompilerTest_compilerplugins_clang.mk | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk index aed44a29e85c..dff61e873af4 100644 --- a/solenv/CompilerTest_compilerplugins_clang.mk +++ b/solenv/CompilerTest_compilerplugins_clang.mk @@ -56,6 +56,7 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/oslendian-1 \ compilerplugins/clang/test/oslendian-2 \ compilerplugins/clang/test/oslendian-3 \ + compilerplugins/clang/test/ostr \ compilerplugins/clang/test/overridevirtual \ compilerplugins/clang/test/passparamsbyref \ compilerplugins/clang/test/passstuffbyref \ |