diff options
author | Miklos Vajna <vmiklos@collabora.com> | 2024-09-11 08:26:02 +0200 |
---|---|---|
committer | Caolán McNamara <caolan.mcnamara@collabora.com> | 2024-09-12 13:29:08 +0200 |
commit | 4cb25fa922f21996d9106c8a40e26613d47cb3b4 (patch) | |
tree | 186fb2d00e537d803095ff023929d88d6b2f9f7f /solenv | |
parent | b46628863a68a5239aeae06298f9675193009644 (diff) |
cool#9992 lok doc sign: async read-write DigitalSignaturesDialog
This finally allows removing the hack for the LOK case in
SfxObjectShell::CheckIsReadonly() to show the signatures dialog
read-only.
Also fix a case while signing PDFs where the file stream was on the
stack, but now that we finish signing in an async callback, signing
crashed due to a use-after-free.
Fix that by giving the std::unique_ptr to the utl::OStreamWrapper ctor,
which knows to take over ownership in this case, and that wrapper is
reference-counted.
Next problem is that the add/remove buttons in the dialog are still
hidden in the LOK case, that's not yet fixed here.
(cherry picked from commit 482c7c585160681b263c6245a745c21df70e7507)
Change-Id: I71ee50ae55d4e62f5d265a35e3810e3b2b63a9b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173244
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Diffstat (limited to 'solenv')
0 files changed, 0 insertions, 0 deletions