diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-07-01 16:45:28 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-07-01 19:50:42 +0200 |
| commit | 631cec87e2da1925246e4a1902cec6f2952f939e (patch) | |
| tree | f1fe33bdb76a9ec051342834757d5fb8737f14e2 /solenv | |
| parent | 740d87c0cc833a8159d79100f789033750a8427c (diff) | |
loplugin:externvar is covered by loplugin:external
...so drop the former. But keep the relevant externvar tests by moving them
into compilerplugins/clang/test/external.cxx. (Which revealed one difference
between the two plugins, regarding certain extern "C" variables in unnamed
namespaces, where Clang (and for that matter also e.g. GCC, it appears)
deliberately deviates from the Standard and considers them to have external
linkage. Add clarifying comments that loplugin:external keeps considering these
as having internal linkage, following the Standard.)
Change-Id: I344fcd0135fdaf6bf08a4b396af2ed2299389a7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97639
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/CompilerTest_compilerplugins_clang.mk | 1 | ||||
| -rw-r--r-- | solenv/clang-format/blacklist | 4 |
2 files changed, 1 insertions, 4 deletions
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk index 3d457af768df..d4612b628838 100644 --- a/solenv/CompilerTest_compilerplugins_clang.mk +++ b/solenv/CompilerTest_compilerplugins_clang.mk @@ -35,7 +35,6 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/emptyif \ compilerplugins/clang/test/expressionalwayszero \ compilerplugins/clang/test/external \ - compilerplugins/clang/test/externvar \ compilerplugins/clang/test/faileddyncast \ compilerplugins/clang/test/fakebool \ compilerplugins/clang/test/finalprotected \ diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist index 2ffa91497589..52d307c81f1b 100644 --- a/solenv/clang-format/blacklist +++ b/solenv/clang-format/blacklist @@ -1652,7 +1652,6 @@ compilerplugins/clang/dynexcspec.cxx compilerplugins/clang/expandablemethods.cxx compilerplugins/clang/expressionalwayszero.cxx compilerplugins/clang/externandnotdefined.cxx -compilerplugins/clang/externvar.cxx compilerplugins/clang/faileddyncast.cxx compilerplugins/clang/fakebool.cxx compilerplugins/clang/finalclasses.cxx @@ -1760,8 +1759,7 @@ compilerplugins/clang/test/cppunitassertequals.hxx compilerplugins/clang/test/datamembershadow.cxx compilerplugins/clang/test/dodgyswitch.cxx compilerplugins/clang/test/expressionalwayszero.cxx -compilerplugins/clang/test/externvar.cxx -compilerplugins/clang/test/externvar.hxx +compilerplugins/clang/test/external.hxx compilerplugins/clang/test/faileddyncast.cxx compilerplugins/clang/test/fakebool.cxx compilerplugins/clang/test/finalprotected.cxx |