gla11y: Enable button labelling warnings

Change-Id: Ie6a45060e252e75b76fb6222d02403de6d4bccfd
Reviewed-on: https://gerrit.libreoffice.org/52968
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

13 files changed, 127 insertions, 1 deletions

diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk
index 36ffdeb0d511..1d9ede0986d1 100644
--- a/solenv/gbuild/UIConfig.mk
+++ b/solenv/gbuild/UIConfig.mk
@@ -165,7 +165,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for
 gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by
 
 # These are often buttons with only an image
-#gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label
+gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label
 # These are often doubtful
 #gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic
 
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index 598c7a600ae3..3cf4f506104c 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -1,3 +1,5 @@
+cui/uiconfig/ui/comment.ui://GtkButton[@id='previous'] button-no-label
+cui/uiconfig/ui/comment.ui://GtkButton[@id='next'] button-no-label
 cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by
 cui/uiconfig/ui/gradientpage.ui://GtkLabel[@id='centerft'] orphan-label
 cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='borderslider'] no-labelled-by
@@ -6,3 +8,42 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='angleft'] orphan-label
 cui/uiconfig/ui/hatchpage.ui://GtkScale[@id='angleslider'] no-labelled-by
 cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linetypeft'] orphan-label
 cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label
+cui/uiconfig/ui/hyphenate.ui://GtkLabel[@id='label1'] orphan-label
+cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='left'] button-no-label
+cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='right'] button-no-label
+cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='browsetitle'] orphan-label
+cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='suppress'] orphan-label
+cui/uiconfig/ui/optemailpage.ui://GtkCheckButton[@id='suppressHidden'] button-no-label
+cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='always'] orphan-label
+cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='screenonly'] orphan-label
+cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='font'] orphan-label
+cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='replacewith'] orphan-label
+cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='apply'] button-no-label
+cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='delete'] button-no-label
+cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default1'] button-no-label
+cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default2'] button-no-label
+cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default3'] button-no-label
+cui/uiconfig/ui/personalization_tab.ui://GtkLabel[@id='applied_theme'] orphan-label
+cui/uiconfig/ui/personalization_tab.ui://GtkLabel[@id='extensions_label'] orphan-label
+cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='persona_preview'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion1'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion2'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion3'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion4'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion5'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion6'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result1'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result2'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result3'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result4'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result5'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result6'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result7'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result8'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result9'] button-no-label
+cui/uiconfig/ui/select_persona_dialog.ui://GtkLabel[@id='progress_label'] orphan-label
+cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinPageNumber'] missing-label-for
+cui/uiconfig/ui/textflowpage.ui://GtkComboBox[@id='comboPageStyle'] missing-label-for
+cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinOrphan'] missing-label-for
+cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinWidow'] missing-label-for
+cui/uiconfig/ui/thesaurus.ui://GtkButton[@id='left'] button-no-label
diff --git a/solenv/sanitizers/ui/dbaccess.suppr b/solenv/sanitizers/ui/dbaccess.suppr
new file mode 100644
index 000000000000..65f01f88f4b9
--- /dev/null
+++ b/solenv/sanitizers/ui/dbaccess.suppr
@@ -0,0 +1,14 @@
+dbaccess/uiconfig/ui/applycolpage.ui://GtkButton[@id='colrh'] button-no-label
+dbaccess/uiconfig/ui/applycolpage.ui://GtkButton[@id='colsrh'] button-no-label
+dbaccess/uiconfig/ui/applycolpage.ui://GtkButton[@id='collh'] button-no-label
+dbaccess/uiconfig/ui/applycolpage.ui://GtkButton[@id='colslh'] button-no-label
+dbaccess/uiconfig/ui/dbaseindexdialog.ui://GtkButton[@id='add'] button-no-label
+dbaccess/uiconfig/ui/dbaseindexdialog.ui://GtkButton[@id='addall'] button-no-label
+dbaccess/uiconfig/ui/dbaseindexdialog.ui://GtkButton[@id='remove'] button-no-label
+dbaccess/uiconfig/ui/dbaseindexdialog.ui://GtkButton[@id='removeall'] button-no-label
+dbaccess/uiconfig/ui/namematchingpage.ui://GtkButton[@id='up'] button-no-label
+dbaccess/uiconfig/ui/namematchingpage.ui://GtkButton[@id='down'] button-no-label
+dbaccess/uiconfig/ui/namematchingpage.ui://GtkLabel[@id='leftlabel'] orphan-label
+dbaccess/uiconfig/ui/namematchingpage.ui://GtkLabel[@id='rightlabel'] orphan-label
+dbaccess/uiconfig/ui/namematchingpage.ui://GtkButton[@id='up_right'] button-no-label
+dbaccess/uiconfig/ui/namematchingpage.ui://GtkButton[@id='down_right'] button-no-label
diff --git a/solenv/sanitizers/ui/formula.suppr b/solenv/sanitizers/ui/formula.suppr
new file mode 100644
index 000000000000..ed40a4a2f74c
--- /dev/null
+++ b/solenv/sanitizers/ui/formula.suppr
@@ -0,0 +1,7 @@
+formula/uiconfig/ui/parameter.ui://GtkLabel[@id='editdesc'] orphan-label
+formula/uiconfig/ui/parameter.ui://GtkLabel[@id='parname'] orphan-label
+formula/uiconfig/ui/parameter.ui://GtkLabel[@id='pardesc'] orphan-label
+formula/uiconfig/ui/parameter.ui://GtkButton[@id='FX1'] button-no-label
+formula/uiconfig/ui/parameter.ui://GtkButton[@id='FX2'] button-no-label
+formula/uiconfig/ui/parameter.ui://GtkButton[@id='FX3'] button-no-label
+formula/uiconfig/ui/parameter.ui://GtkButton[@id='FX4'] button-no-label
diff --git a/solenv/sanitizers/ui/fps.suppr b/solenv/sanitizers/ui/fps.suppr
new file mode 100644
index 000000000000..b3d0303f0dbe
--- /dev/null
+++ b/solenv/sanitizers/ui/fps.suppr
@@ -0,0 +1,3 @@
+fpicker/uiconfig/ui/explorerfiledialog.ui://GtkLabel[@id='shared_label'] orphan-label
+fpicker/uiconfig/ui/explorerfiledialog.ui://GtkCheckButton[@id='link'] button-no-label
+fpicker/uiconfig/ui/explorerfiledialog.ui://GtkCheckButton[@id='cb_preview'] button-no-label
diff --git a/solenv/sanitizers/ui/modules/dbreport.suppr b/solenv/sanitizers/ui/modules/dbreport.suppr
new file mode 100644
index 000000000000..12f4195d8cd8
--- /dev/null
+++ b/solenv/sanitizers/ui/modules/dbreport.suppr
@@ -0,0 +1,4 @@
+reportdesign/uiconfig/dbreport/ui/conditionwin.ui://GtkLabel[@id='headerLabel'] orphan-label
+reportdesign/uiconfig/dbreport/ui/conditionwin.ui://GtkLabel[@id='andLabel'] orphan-label
+reportdesign/uiconfig/dbreport/ui/conditionwin.ui://GtkButton[@id='upButton'] button-no-label
+reportdesign/uiconfig/dbreport/ui/conditionwin.ui://GtkButton[@id='downButton'] button-no-label
diff --git a/solenv/sanitizers/ui/modules/scanner.suppr b/solenv/sanitizers/ui/modules/scanner.suppr
new file mode 100644
index 000000000000..96ef2f298438
--- /dev/null
+++ b/solenv/sanitizers/ui/modules/scanner.suppr
@@ -0,0 +1,3 @@
+extensions/uiconfig/scanner/ui/sanedialog.ui://GtkLabel[@id='optionTitleLabel:border'] orphan-label
+extensions/uiconfig/scanner/ui/sanedialog.ui://GtkLabel[@id='optionsDescLabel'] orphan-label
+extensions/uiconfig/scanner/ui/sanedialog.ui://GtkCheckButton[@id='boolCheckbutton'] button-no-label
diff --git a/solenv/sanitizers/ui/modules/schart.suppr b/solenv/sanitizers/ui/modules/schart.suppr
new file mode 100644
index 000000000000..31c5cd5f8bce
--- /dev/null
+++ b/solenv/sanitizers/ui/modules/schart.suppr
@@ -0,0 +1,6 @@
+chart2/uiconfig/ui/dlg_InsertErrorBars.ui://GtkRadioButton[@id='RB_FUNCTION'] button-no-label
+chart2/uiconfig/ui/tp_DataSource.ui://GtkLabel[@id='FT_CAPTION_FOR_WIZARD'] orphan-label
+chart2/uiconfig/ui/tp_DataSource.ui://GtkButton[@id='IMB_RANGE_MAIN'] button-no-label
+chart2/uiconfig/ui/tp_DataSource.ui://GtkLabel[@id='FT_DATALABELS'] orphan-label
+chart2/uiconfig/ui/tp_DataSource.ui://GtkButton[@id='IMB_RANGE_CAT'] button-no-label
+chart2/uiconfig/ui/tp_ErrorBars.ui://GtkRadioButton[@id='RB_FUNCTION'] button-no-label
diff --git a/solenv/sanitizers/ui/modules/simpress.suppr b/solenv/sanitizers/ui/modules/simpress.suppr
index c2c8874d28da..0ce12d499983 100644
--- a/solenv/sanitizers/ui/modules/simpress.suppr
+++ b/solenv/sanitizers/ui/modules/simpress.suppr
@@ -1,3 +1,12 @@
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkLabel[@id='start_effect'] orphan-label
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkLabel[@id='effect_property'] orphan-label
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkLabel[@id='categorylabel'] orphan-label
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkLabel[@id='effect_duration'] orphan-label
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkLabel[@id='delay_label'] orphan-label
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkLabel[@id='effectlabel'] orphan-label
+sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui://GtkButton[@id='more_properties'] button-no-label
+sd/uiconfig/simpress/ui/customanimationeffecttab.ui://GtkButton[@id='sound_preview'] button-no-label
+sd/uiconfig/simpress/ui/customanimationeffecttab.ui://GtkLabel[@id='text_delay_label'] orphan-label
 sd/uiconfig/simpress/ui/headerfootertab.ui://GtkRadioButton[@id='rb_auto'] missing-label-for
 sd/uiconfig/simpress/ui/prntopts.ui://GtkCheckButton[@id='frontcb'] missing-label-for
 sd/uiconfig/simpress/ui/prntopts.ui://GtkCheckButton[@id='backcb'] missing-label-for
diff --git a/solenv/sanitizers/ui/modules/swriter.suppr b/solenv/sanitizers/ui/modules/swriter.suppr
index 7b6e82b77479..997026c1bcb1 100644
--- a/solenv/sanitizers/ui/modules/swriter.suppr
+++ b/solenv/sanitizers/ui/modules/swriter.suppr
@@ -1,8 +1,41 @@
+sw/uiconfig/swriter/ui/addressblockdialog.ui://GtkButton[@id='toaddr'] button-no-label
+sw/uiconfig/swriter/ui/customizeaddrlistdialog.ui://GtkButton[@id='down'] button-no-label
+sw/uiconfig/swriter/ui/customizeaddrlistdialog.ui://GtkButton[@id='up'] button-no-label
+sw/uiconfig/swriter/ui/dropdownfielddialog.ui://GtkButton[@id='prev'] button-no-label
+sw/uiconfig/swriter/ui/dropdownfielddialog.ui://GtkButton[@id='next'] button-no-label
 sw/uiconfig/swriter/ui/frmtypepage.ui://GtkCheckButton[@id='relwidth'] missing-labelled-by
 sw/uiconfig/swriter/ui/frmtypepage.ui://GtkCheckButton[@id='relheight'] missing-labelled-by
+sw/uiconfig/swriter/ui/headerfootermenu.ui://GtkMenuItem[@id='edit'] button-no-label
+sw/uiconfig/swriter/ui/headerfootermenu.ui://GtkMenuItem[@id='delete'] button-no-label
+sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='previous'] button-no-label
+sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='next'] button-no-label
+sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='first'] button-no-label
+sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='last'] button-no-label
+sw/uiconfig/swriter/ui/inputfielddialog.ui://GtkButton[@id='prev'] button-no-label
+sw/uiconfig/swriter/ui/inputfielddialog.ui://GtkButton[@id='next'] button-no-label
 sw/uiconfig/swriter/ui/insertbreak.ui://GtkSpinButton[@id='pagenumsb'] missing-label-for
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='allright'] button-no-label
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='oneright'] button-no-label
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='toedit'] button-no-label
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='oneleft'] button-no-label
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='allleft'] button-no-label
 sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkComboBoxText[@id='parastyle'] missing-label-for
+sw/uiconfig/swriter/ui/insertfootnote.ui://GtkButton[@id='prev'] button-no-label
+sw/uiconfig/swriter/ui/insertfootnote.ui://GtkButton[@id='next'] button-no-label
+sw/uiconfig/swriter/ui/insertscript.ui://GtkButton[@id='previous'] button-no-label
+sw/uiconfig/swriter/ui/insertscript.ui://GtkButton[@id='next'] button-no-label
+sw/uiconfig/swriter/ui/insertscript.ui://GtkLabel[@id='label1'] orphan-label
 sw/uiconfig/swriter/ui/numparapage.ui://GtkCheckButton[@id='checkCB_NUMBER_NEW_START'] missing-labelled-by
+sw/uiconfig/swriter/ui/readonlymenu.ui://GtkMenuItem[@id='backgroundtogallery'] button-no-label
+sw/uiconfig/swriter/ui/readonlymenu.ui://GtkMenuItem[@id='backaslink'] button-no-label
+sw/uiconfig/swriter/ui/readonlymenu.ui://GtkMenuItem[@id='backascopy'] button-no-label
+sw/uiconfig/swriter/ui/spellmenu.ui://GtkMenuItem[@id='spelldialog'] button-no-label
+sw/uiconfig/swriter/ui/spellmenu.ui://GtkMenuItem[@id='correctdialog'] button-no-label
 sw/uiconfig/swriter/ui/tocindexpage.ui://GtkButton[@id='styles'] missing-label-for
+sw/uiconfig/swriter/ui/tocstylespage.ui://GtkButton[@id='assign'] button-no-label
+sw/uiconfig/swriter/ui/tablecolumnpage.ui://GtkButton[@id='back'] button-no-label
+sw/uiconfig/swriter/ui/tablecolumnpage.ui://GtkButton[@id='next'] button-no-label
 sw/uiconfig/swriter/ui/tabletextflowpage.ui://GtkSpinButton[@id='pagenonf'] missing-label-for
 sw/uiconfig/swriter/ui/titlepage.ui://GtkSpinButton[@id='NF_PAGE_START'] missing-label-for
+sw/uiconfig/swriter/ui/tokenwidget.ui://GtkButton[@id='left'] button-no-label
+sw/uiconfig/swriter/ui/tokenwidget.ui://GtkButton[@id='right'] button-no-label
diff --git a/solenv/sanitizers/ui/svt.suppr b/solenv/sanitizers/ui/svt.suppr
index 64325dcb38dd..dd83b647951a 100644
--- a/solenv/sanitizers/ui/svt.suppr
+++ b/solenv/sanitizers/ui/svt.suppr
@@ -1,2 +1,3 @@
 svtools/uiconfig/ui/graphicexport.ui://GtkScale[@id='compressionjpgsb'] no-labelled-by
 svtools/uiconfig/ui/graphicexport.ui://GtkScale[@id='compressionpngsb'] no-labelled-by
+svtools/uiconfig/ui/placeedit.ui://GtkButton[@id='repositoriesRefresh'] button-no-label
diff --git a/solenv/sanitizers/ui/svx.suppr b/solenv/sanitizers/ui/svx.suppr
index c10ad8d7092c..dd932ed8faa9 100644
--- a/solenv/sanitizers/ui/svx.suppr
+++ b/solenv/sanitizers/ui/svx.suppr
@@ -1,3 +1,5 @@
+svx/uiconfig/ui/colorwindow.ui://GtkButton[@id='auto_color_button'] button-no-label
+svx/uiconfig/ui/colorwindow.ui://GtkLabel[@id='label1'] orphan-label
 svx/uiconfig/ui/compressgraphicdialog.ui://GtkScale[@id='scale-quality'] no-labelled-by
 svx/uiconfig/ui/compressgraphicdialog.ui://GtkScale[@id='scale-compression'] no-labelled-by
 svx/uiconfig/ui/mediaplayback.ui://GtkLabel[@id='label1'] orphan-label
diff --git a/solenv/sanitizers/ui/vcl.suppr b/solenv/sanitizers/ui/vcl.suppr
new file mode 100644
index 000000000000..fea324551dc6
--- /dev/null
+++ b/solenv/sanitizers/ui/vcl.suppr
@@ -0,0 +1,3 @@
+vcl/uiconfig/ui/printdialog.ui://GtkLabel[@id='totalnumpages'] orphan-label
+vcl/uiconfig/ui/printdialog.ui://GtkButton[@id='forward'] button-no-label
+vcl/uiconfig/ui/printdialog.ui://GtkButton[@id='backward'] button-no-label