summaryrefslogtreecommitdiff
path: root/soltools/cpp
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-08-14 08:28:13 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-08-14 09:14:39 +0200
commit0c3bd1d482ece1f2217cc87069179161f6a5bb56 (patch)
tree86bab8ab624fd60076838f068f010372321a204b /soltools/cpp
parent11535357df4e4ec828435229ff784b9868ee583a (diff)
new loplugin:droplong
The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholy unsuitable for portable code. And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different bit sizes. Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d Reviewed-on: https://gerrit.libreoffice.org/41130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'soltools/cpp')
-rw-r--r--soltools/cpp/_eval.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/soltools/cpp/_eval.c b/soltools/cpp/_eval.c
index e1eceb204371..498fda740e89 100644
--- a/soltools/cpp/_eval.c
+++ b/soltools/cpp/_eval.c
@@ -28,7 +28,7 @@
struct value
{
- long val;
+ int val;
int type;
};
@@ -407,7 +407,7 @@ int
{
struct value v1;
struct value v2 = { 0, UND };
- long rv1, rv2;
+ int rv1, rv2;
int rtype, oper;
rv2 = 0;
@@ -620,7 +620,7 @@ struct value
struct value v;
Nlist *np;
int i, base;
- unsigned long n;
+ unsigned int n;
uchar *p, c;
v.type = SGN;