summaryrefslogtreecommitdiff
path: root/sot/source
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-07-11 09:57:47 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-07-11 12:55:47 +0200
commit00850e3fa71cc9ebeacad65f54a98b9a79a8b183 (patch)
tree69fef16ff20bb6e8b74d093bb3a31201bb72ceb8 /sot/source
parentce795510d3de7beb6bcd39954280bc3b5778ec6e (diff)
clean up UNO available() implementations
There seems to be some confusion here. available() is actually the number of bytes that can be read without blocking, but most implementations seems to be just returning the number of bytes remaining in the stream. Since we're doing that, let's do it properly. (*) some of them were just casting, instead of clamping, which will return wrong values sometimes. (*) FileStreamWrapper_Impl/OInputStreamWrapper/OTempFileService were doing unnecessary work, instead of just asking the underlying SvStream for it's remaining size Change-Id: I3ef26e0363e989ed3e00be0fdb993e1cdeb7819f Reviewed-on: https://gerrit.libreoffice.org/57264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sot/source')
-rw-r--r--sot/source/sdstor/ucbstorage.cxx11
1 files changed, 2 insertions, 9 deletions
diff --git a/sot/source/sdstor/ucbstorage.cxx b/sot/source/sdstor/ucbstorage.cxx
index d7ffbbf7a756..a9780879e907 100644
--- a/sot/source/sdstor/ucbstorage.cxx
+++ b/sot/source/sdstor/ucbstorage.cxx
@@ -203,17 +203,10 @@ sal_Int32 SAL_CALL FileStreamWrapper_Impl::available()
::osl::MutexGuard aGuard( m_aMutex );
checkConnected();
- sal_uInt32 nPos = m_pSvStream->Tell();
- checkError();
-
- m_pSvStream->Seek(STREAM_SEEK_TO_END);
- checkError();
-
- sal_Int32 nAvailable = static_cast<sal_Int32>(m_pSvStream->Tell()) - nPos;
- m_pSvStream->Seek(nPos);
+ sal_Int64 nAvailable = m_pSvStream->remainingSize();
checkError();
- return nAvailable;
+ return std::min<sal_Int64>(SAL_MAX_INT32, nAvailable);
}