diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 09:07:25 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 23:42:26 +0000 |
commit | 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 (patch) | |
tree | f8b8cea0a81bc74ca34e8bda2d0dfce939b28ce0 /sot | |
parent | 20deac4903fc0697477e855feeff482b3da234f9 (diff) |
callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
Diffstat (limited to 'sot')
-rw-r--r-- | sot/source/base/factory.cxx | 14 | ||||
-rw-r--r-- | sot/source/sdstor/storage.cxx | 84 |
2 files changed, 0 insertions, 98 deletions
diff --git a/sot/source/base/factory.cxx b/sot/source/base/factory.cxx index 5cc444ff1aa3..cade244c5698 100644 --- a/sot/source/base/factory.cxx +++ b/sot/source/base/factory.cxx @@ -187,17 +187,6 @@ void SotFactory::DecSvObjectCount( SotObject * pObj ) } /************************************************************************* -|* SotFactory::CreateInstance() -|* -|* Beschreibung -*************************************************************************/ -void * SotFactory::CreateInstance( SotObject ** ppObj ) const -{ - assert(pCreateFunc && "SotFactory::CreateInstance: pCreateFunc == 0"); - return pCreateFunc( ppObj ); -} - -/************************************************************************* |* SotFactory::Is() |* |* Beschreibung @@ -215,7 +204,4 @@ bool SotFactory::Is( const SotFactory * pSuperCl ) const return false; } - - - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sot/source/sdstor/storage.cxx b/sot/source/sdstor/storage.cxx index 30262d25fc49..6de540de9d3b 100644 --- a/sot/source/sdstor/storage.cxx +++ b/sot/source/sdstor/storage.cxx @@ -267,16 +267,6 @@ bool SotStorageStream::Commit() return GetError() == SVSTREAM_OK; } -bool SotStorageStream::Revert() -{ - if( pOwnStm ) - { - pOwnStm->Revert(); - SetError( pOwnStm->GetError() ); - } - return GetError() == SVSTREAM_OK; -} - bool SotStorageStream::SetProperty( const OUString& rName, const ::com::sun::star::uno::Any& rValue ) { UCBStorageStream* pStg = PTR_CAST( UCBStorageStream, pOwnStm ); @@ -615,14 +605,6 @@ const OUString & SotStorage::GetName() const return m_aName; } - -void SotStorage::ResetError() -{ - m_nError = SVSTREAM_OK; - if( m_pOwnStg ) - m_pOwnStg->ResetError(); -} - void SotStorage::SetClass( const SvGlobalName & rName, sal_uLong nOriginalClipFormat, const OUString & rUserTypeName ) @@ -634,17 +616,6 @@ void SotStorage::SetClass( const SvGlobalName & rName, SetError( SVSTREAM_GENERALERROR ); } -void SotStorage::SetConvertClass( const SvGlobalName & rName, - sal_uLong nOriginalClipFormat, - const OUString & rUserTypeName ) -{ - DBG_ASSERT( Owner(), "must be owner" ); - if( m_pOwnStg ) - m_pOwnStg->SetConvertClass( rName, nOriginalClipFormat, rUserTypeName ); - else - SetError( SVSTREAM_GENERALERROR ); -} - SvGlobalName SotStorage::GetClassName() { SvGlobalName aGN; @@ -678,16 +649,6 @@ OUString SotStorage::GetUserName() return aName; } -bool SotStorage::ShouldConvert() -{ - DBG_ASSERT( Owner(), "must be owner" ); - if( m_pOwnStg ) - return m_pOwnStg->ShouldConvert(); - else - SetError( SVSTREAM_GENERALERROR ); - return false; -} - void SotStorage::FillInfoList( SvStorageInfoList * pFillList ) const { DBG_ASSERT( Owner(), "must be owner" ); @@ -726,20 +687,6 @@ bool SotStorage::Commit() return SVSTREAM_OK == GetError(); } -bool SotStorage::Revert() -{ - DBG_ASSERT( Owner(), "must be owner" ); - if( m_pOwnStg ) - { - if( !m_pOwnStg->Revert() ) - SetError( m_pOwnStg->GetError() ); - } - else - SetError( SVSTREAM_GENERALERROR ); - - return SVSTREAM_OK == GetError(); -} - SotStorageStream * SotStorage::OpenSotStream( const OUString & rEleName, StreamMode nMode, StorageMode nStorageMode ) @@ -837,20 +784,6 @@ bool SotStorage::Remove( const OUString & rEleName ) return SVSTREAM_OK == GetError(); } -bool SotStorage::Rename( const OUString & rEleName, const OUString & rNewName ) -{ - DBG_ASSERT( Owner(), "must be owner" ); - if( m_pOwnStg ) - { - m_pOwnStg->Rename( rEleName, rNewName ); - SetError( m_pOwnStg->GetError() ); - } - else - SetError( SVSTREAM_GENERALERROR ); - - return SVSTREAM_OK == GetError(); -} - bool SotStorage::CopyTo( const OUString & rEleName, SotStorage * pNewSt, const OUString & rNewName ) { @@ -868,23 +801,6 @@ bool SotStorage::CopyTo( const OUString & rEleName, return SVSTREAM_OK == GetError(); } -bool SotStorage::MoveTo( const OUString & rEleName, - SotStorage * pNewSt, const OUString & rNewName ) -{ - DBG_ASSERT( Owner(), "must be owner" ); - DBG_ASSERT( pNewSt->Owner(), "must be owner" ); - if( m_pOwnStg ) - { - m_pOwnStg->MoveTo( rEleName, pNewSt->m_pOwnStg, rNewName ); - SetError( m_pOwnStg->GetError() ); - SetError( pNewSt->GetError() ); - } - else - SetError( SVSTREAM_GENERALERROR ); - - return SVSTREAM_OK == GetError(); -} - bool SotStorage::Validate() { DBG_ASSERT( m_bIsRoot, "Validate nur an Rootstorage" ); |