diff options
author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /starmath/inc/cursor.hxx | |
parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'starmath/inc/cursor.hxx')
-rw-r--r-- | starmath/inc/cursor.hxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/starmath/inc/cursor.hxx b/starmath/inc/cursor.hxx index b1f6e8b57929..ca3527dda94d 100644 --- a/starmath/inc/cursor.hxx +++ b/starmath/inc/cursor.hxx @@ -121,7 +121,7 @@ public: void DeletePrev(OutputDevice* pDev); /** Insert text at the current position */ - void InsertText(OUString aString); + void InsertText(const OUString& aString); /** Insert an element into the formula */ void InsertElement(SmFormulaElement element); @@ -137,7 +137,7 @@ public: * This will work for stuff like "A intersection B". But stuff spaning multiple lines * or dependent on the context which position is placed in will not work! */ - void InsertCommandText(OUString aCommandText); + void InsertCommandText(const OUString& aCommandText); /** Insert a special node created from aString * @@ -148,7 +148,7 @@ public: * For more complex expressions use InsertCommandText, this method doesn't * use SmParser, this means that it's faster, but not as strong. */ - void InsertSpecial(OUString aString); + void InsertSpecial(const OUString& aString); /** Create sub-/super script * |