make the Color constructors explicitly specify transparency

to reduce the churn, we leave the existing constructor in place,
and add a clang plugin to detect when the value passed to the
existing constructor may contain transparency/alpha data.

i.e. we leave expressions like Color(0xffffff) alone, but
warn about any non-constant expression, and any expression
like Color(0xff000000)

Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 1 insertions, 1 deletions

diff --git a/starmath/inc/token.hxx b/starmath/inc/token.hxx
index cc295cc5fe28..cb485a531ac8 100644
--- a/starmath/inc/token.hxx
+++ b/starmath/inc/token.hxx
@@ -200,7 +200,7 @@ struct SmColorTokenTableEntry
         : pIdent(name)
         , cIdent(codename)
         , eType(ctype)
-        , cColor(ncolor)
+        , cColor(ColorTransparency, ncolor)
     {
     }