diff options
author | Noel Grandin <noel@peralex.com> | 2016-07-22 14:35:27 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-07-25 06:09:17 +0000 |
commit | 938821fb08e427864db6a10642f385bde9803f6c (patch) | |
tree | 759da9d0d0905a90f6dac2f0bf750721c17421c4 /starmath/source | |
parent | 4d4d77a1aad1bcae18bad35dad5308d33d6b2e51 (diff) |
new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.
Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'starmath/source')
-rw-r--r-- | starmath/source/cursor.cxx | 2 | ||||
-rw-r--r-- | starmath/source/document.cxx | 6 | ||||
-rw-r--r-- | starmath/source/edit.cxx | 2 | ||||
-rw-r--r-- | starmath/source/mathmlexport.hxx | 2 | ||||
-rw-r--r-- | starmath/source/view.cxx | 4 |
5 files changed, 8 insertions, 8 deletions
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx index b1ef0b0e9495..d3a54ff8fe90 100644 --- a/starmath/source/cursor.cxx +++ b/starmath/source/cursor.cxx @@ -1422,7 +1422,7 @@ void SmCursor::EndEdit(){ if ( mbIsEnabledSetModifiedSmDocShell ) mpDocShell->EnableSetModified( mbIsEnabledSetModifiedSmDocShell ); //I think this notifies people around us that we've modified this document... - mpDocShell->SetModified(true); + mpDocShell->SetModified(); //I think SmDocShell uses this value when it sends an update graphics event //Anyway comments elsewhere suggests it need to be updated... mpDocShell->mnModifyCount++; diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx index a6596380b1bc..3bbda764b41c 100644 --- a/starmath/source/document.cxx +++ b/starmath/source/document.cxx @@ -176,7 +176,7 @@ void SmDocShell::SetText(const OUString& rBuffer) if ( bIsEnabled ) EnableSetModified( bIsEnabled ); - SetModified(true); + SetModified(); // launch accessible event if necessary SmGraphicAccessible *pAcc = pViewSh ? pViewSh->GetGraphicWindow().GetAccessible_Impl() : nullptr; @@ -199,7 +199,7 @@ void SmDocShell::SetFormat(SmFormat& rFormat) { maFormat = rFormat; SetFormulaArranged( false ); - SetModified( true ); + SetModified(); mnModifyCount++; //! see comment for SID_GAPHIC_SM in SmDocShell::GetState @@ -614,7 +614,7 @@ void SmDocShell::OnDocumentPrinterChanged( Printer *pPrt ) Size aOldSize = GetVisArea().GetSize(); Repaint(); if( aOldSize != GetVisArea().GetSize() && !maText.isEmpty() ) - SetModified( true ); + SetModified(); mpTmpPrinter = nullptr; } diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx index f4400fcb69c2..69ae86594e43 100644 --- a/starmath/source/edit.cxx +++ b/starmath/source/edit.cxx @@ -963,7 +963,7 @@ void SmEditWindow::UpdateStatus( bool bSetDocModified ) if (pMod && pMod->GetConfig()->IsAutoRedraw()) Flush(); if ( bSetDocModified ) - GetDoc()->SetModified(true); + GetDoc()->SetModified(); } void SmEditWindow::Cut() diff --git a/starmath/source/mathmlexport.hxx b/starmath/source/mathmlexport.hxx index 2a58f570f5d9..791efa6deaaa 100644 --- a/starmath/source/mathmlexport.hxx +++ b/starmath/source/mathmlexport.hxx @@ -106,7 +106,7 @@ public: void ExportAutoStyles_() override {} void ExportMasterStyles_() override {} void ExportContent_() override; - sal_uInt32 exportDoc(enum ::xmloff::token::XMLTokenEnum eClass) override; + sal_uInt32 exportDoc(enum ::xmloff::token::XMLTokenEnum eClass = ::xmloff::token::XML_TOKEN_INVALID) override; virtual void GetViewSettings(css::uno::Sequence<css::beans::PropertyValue>& aProps) override; virtual void GetConfigurationSettings(css::uno::Sequence<css::beans::PropertyValue>& aProps) override; diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx index 82c6e96955e5..eeff4a987a40 100644 --- a/starmath/source/view.cxx +++ b/starmath/source/view.cxx @@ -1361,7 +1361,7 @@ void SmViewShell::Insert( SfxMedium& rMedium ) } pDoc->Parse(); - pDoc->SetModified(true); + pDoc->SetModified(); SfxBindings &rBnd = GetViewFrame()->GetBindings(); rBnd.Invalidate(SID_GAPHIC_SM); @@ -1396,7 +1396,7 @@ void SmViewShell::InsertFrom(SfxMedium &rMedium) SAL_WARN( "starmath", "EditWindow missing" ); pDoc->Parse(); - pDoc->SetModified(true); + pDoc->SetModified(); SfxBindings& rBnd = GetViewFrame()->GetBindings(); rBnd.Invalidate(SID_GAPHIC_SM); |