loplugin:returnconstval in sd..starmath

Change-Id: Ib14f0ebef1c48a00ed09be70cb5885ccd07db762
Reviewed-on: https://gerrit.libreoffice.org/78060
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

10 files changed, 27 insertions, 27 deletions

diff --git a/starmath/inc/document.hxx b/starmath/inc/document.hxx
index 6041e304e2ad..c192ef2fc655 100644
--- a/starmath/inc/document.hxx
+++ b/starmath/inc/document.hxx
@@ -161,7 +161,7 @@ public:
     SfxPrinter *GetPrinter()    { GetPrt(); return mpPrinter; }
     void        SetPrinter( SfxPrinter * );
 
-    const OUString GetComment() const;
+    OUString GetComment() const;
 
     // to replace chars that can not be saved with the document...
     void        ReplaceBadChars();
diff --git a/starmath/inc/rect.hxx b/starmath/inc/rect.hxx
index 8d0bbe931d51..ce390b19724a 100644
--- a/starmath/inc/rect.hxx
+++ b/starmath/inc/rect.hxx
@@ -153,7 +153,7 @@ public:
 
             const Size & GetSize() const    { return aSize; }
 
-            const Size  GetItalicSize() const
+            Size  GetItalicSize() const
             {   return Size(GetItalicWidth(), GetHeight()); }
 
             void Move  (const Point &rPosition);
@@ -166,7 +166,7 @@ public:
 
             bool HasAlignInfo() const { return bHasAlignInfo; }
 
-            const Point AlignTo(const SmRect &rRect, RectPos ePos,
+            Point AlignTo(const SmRect &rRect, RectPos ePos,
                                 RectHorAlign eHor, RectVerAlign eVer) const;
 
             SmRect & ExtendBy(const SmRect &rRect, RectCopyMBL eCopyMode);
diff --git a/starmath/inc/smmod.hxx b/starmath/inc/smmod.hxx
index 297f8a972e50..8c33f5a76baf 100644
--- a/starmath/inc/smmod.hxx
+++ b/starmath/inc/smmod.hxx
@@ -55,11 +55,11 @@ class SmLocalizedSymbolData
 public:
     SmLocalizedSymbolData() = delete;
 
-    static const OUString GetUiSymbolName( const OUString &rExportName );
-    static const OUString GetExportSymbolName( const OUString &rUiName );
+    static OUString GetUiSymbolName( const OUString &rExportName );
+    static OUString GetExportSymbolName( const OUString &rUiName );
 
-    static const OUString GetUiSymbolSetName( const OUString &rExportName );
-    static const OUString GetExportSymbolSetName( const OUString &rUiName );
+    static OUString GetUiSymbolSetName( const OUString &rExportName );
+    static OUString GetExportSymbolSetName( const OUString &rUiName );
 };
 
 class SmModule : public SfxModule, public utl::ConfigurationListener
diff --git a/starmath/inc/symbol.hxx b/starmath/inc/symbol.hxx
index cd40e245c910..9a9a595ed13d 100644
--- a/starmath/inc/symbol.hxx
+++ b/starmath/inc/symbol.hxx
@@ -82,9 +82,9 @@ public:
 
     // symbol sets are for UI purpose only, thus we assemble them here
     std::set< OUString >      GetSymbolSetNames() const;
-    const SymbolPtrVec_t    GetSymbolSet(  const OUString& rSymbolSetName );
+    SymbolPtrVec_t          GetSymbolSet(  const OUString& rSymbolSetName );
 
-    const SymbolPtrVec_t    GetSymbols() const;
+    SymbolPtrVec_t          GetSymbols() const;
     bool                    AddOrReplaceSymbol( const SmSym & rSymbol, bool bForceChange = false );
     void                    RemoveSymbol( const OUString & rSymbolName );
 
diff --git a/starmath/source/cfgitem.cxx b/starmath/source/cfgitem.cxx
index a8f246423c21..b77ba7b2938f 100644
--- a/starmath/source/cfgitem.cxx
+++ b/starmath/source/cfgitem.cxx
@@ -176,7 +176,7 @@ SmFontFormat::SmFontFormat( const vcl::Font &rFont )
 }
 
 
-const vcl::Font SmFontFormat::GetFont() const
+vcl::Font SmFontFormat::GetFont() const
 {
     vcl::Font aRes;
     aRes.SetFamilyName( aName );
@@ -280,7 +280,7 @@ const SmFontFormat * SmFontFormatList::GetFontFormat( size_t nPos ) const
 }
 
 
-const OUString SmFontFormatList::GetFontFormatId( const SmFontFormat &rFntFmt ) const
+OUString SmFontFormatList::GetFontFormatId( const SmFontFormat &rFntFmt ) const
 {
     OUString aRes;
 
@@ -297,7 +297,7 @@ const OUString SmFontFormatList::GetFontFormatId( const SmFontFormat &rFntFmt )
 }
 
 
-const OUString SmFontFormatList::GetFontFormatId( const SmFontFormat &rFntFmt, bool bAdd )
+OUString SmFontFormatList::GetFontFormatId( const SmFontFormat &rFntFmt, bool bAdd )
 {
     OUString aRes( GetFontFormatId( rFntFmt) );
     if (aRes.isEmpty()  &&  bAdd)
@@ -309,7 +309,7 @@ const OUString SmFontFormatList::GetFontFormatId( const SmFontFormat &rFntFmt, b
 }
 
 
-const OUString SmFontFormatList::GetFontFormatId( size_t nPos ) const
+OUString SmFontFormatList::GetFontFormatId( size_t nPos ) const
 {
     OUString aRes;
     if (nPos < aEntries.size())
@@ -318,7 +318,7 @@ const OUString SmFontFormatList::GetFontFormatId( size_t nPos ) const
 }
 
 
-const OUString SmFontFormatList::GetNewFontFormatId() const
+OUString SmFontFormatList::GetNewFontFormatId() const
 {
     // returns first unused FormatId
 
diff --git a/starmath/source/cfgitem.hxx b/starmath/source/cfgitem.hxx
index 4f1eabf0876d..e6f968583c1e 100644
--- a/starmath/source/cfgitem.hxx
+++ b/starmath/source/cfgitem.hxx
@@ -52,7 +52,7 @@ struct SmFontFormat
     SmFontFormat();
     explicit SmFontFormat( const vcl::Font &rFont );
 
-    const vcl::Font GetFont() const;
+    vcl::Font       GetFont() const;
     bool            operator == ( const SmFontFormat &rFntFmt ) const;
 };
 
@@ -81,10 +81,10 @@ public:
 
     const SmFontFormat *    GetFontFormat( const OUString &rFntFmtId ) const;
     const SmFontFormat *    GetFontFormat( size_t nPos ) const;
-    const OUString          GetFontFormatId( const SmFontFormat &rFntFmt ) const;
-    const OUString          GetFontFormatId( const SmFontFormat &rFntFmt, bool bAdd );
-    const OUString          GetFontFormatId( size_t nPos ) const;
-    const OUString          GetNewFontFormatId() const;
+    OUString                GetFontFormatId( const SmFontFormat &rFntFmt ) const;
+    OUString                GetFontFormatId( const SmFontFormat &rFntFmt, bool bAdd );
+    OUString                GetFontFormatId( size_t nPos ) const;
+    OUString                GetNewFontFormatId() const;
     size_t                  GetCount() const    { return aEntries.size(); }
 
     bool    IsModified() const          { return bModified; }
diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index bd0c67081f51..b3c7c512e3b0 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -120,7 +120,7 @@ void SmDocShell::LoadSymbols()
 }
 
 
-const OUString SmDocShell::GetComment() const
+OUString SmDocShell::GetComment() const
 {
     uno::Reference<document::XDocumentPropertiesSupplier> xDPS(
         GetModel(), uno::UNO_QUERY_THROW);
diff --git a/starmath/source/rect.cxx b/starmath/source/rect.cxx
index bb1a1628dd85..19ba9d1d3007 100644
--- a/starmath/source/rect.cxx
+++ b/starmath/source/rect.cxx
@@ -333,7 +333,7 @@ void SmRect::Move(const Point &rPosition)
 }
 
 
-const Point SmRect::AlignTo(const SmRect &rRect, RectPos ePos,
+Point SmRect::AlignTo(const SmRect &rRect, RectPos ePos,
                             RectHorAlign eHor, RectVerAlign eVer) const
 {   Point  aPos (GetTopLeft());
         // will become the topleft point of the new rectangle position
diff --git a/starmath/source/smmod.cxx b/starmath/source/smmod.cxx
index cfa7048d23a0..93a0ca2053de 100644
--- a/starmath/source/smmod.cxx
+++ b/starmath/source/smmod.cxx
@@ -45,7 +45,7 @@ OUString SmResId(const char* pId)
     return Translate::get(pId, SM_MOD()->GetResLocale());
 }
 
-const OUString SmLocalizedSymbolData::GetUiSymbolName( const OUString &rExportName )
+OUString SmLocalizedSymbolData::GetUiSymbolName( const OUString &rExportName )
 {
     OUString aRes;
 
@@ -61,7 +61,7 @@ const OUString SmLocalizedSymbolData::GetUiSymbolName( const OUString &rExportNa
     return aRes;
 }
 
-const OUString SmLocalizedSymbolData::GetExportSymbolName( const OUString &rUiName )
+OUString SmLocalizedSymbolData::GetExportSymbolName( const OUString &rUiName )
 {
     OUString aRes;
 
@@ -78,7 +78,7 @@ const OUString SmLocalizedSymbolData::GetExportSymbolName( const OUString &rUiNa
     return aRes;
 }
 
-const OUString SmLocalizedSymbolData::GetUiSymbolSetName( const OUString &rExportName )
+OUString SmLocalizedSymbolData::GetUiSymbolSetName( const OUString &rExportName )
 {
     OUString aRes;
 
@@ -94,7 +94,7 @@ const OUString SmLocalizedSymbolData::GetUiSymbolSetName( const OUString &rExpor
     return aRes;
 }
 
-const OUString SmLocalizedSymbolData::GetExportSymbolSetName( const OUString &rUiName )
+OUString SmLocalizedSymbolData::GetExportSymbolSetName( const OUString &rUiName )
 {
     OUString aRes;
 
diff --git a/starmath/source/symbol.cxx b/starmath/source/symbol.cxx
index e37c69c6726b..22f9cdc376b6 100644
--- a/starmath/source/symbol.cxx
+++ b/starmath/source/symbol.cxx
@@ -121,7 +121,7 @@ SmSym *SmSymbolManager::GetSymbolByName(const OUString& rSymbolName)
 }
 
 
-const SymbolPtrVec_t SmSymbolManager::GetSymbols() const
+SymbolPtrVec_t SmSymbolManager::GetSymbols() const
 {
     SymbolPtrVec_t aRes;
     for (const auto& rEntry : m_aSymbols)
@@ -187,7 +187,7 @@ std::set< OUString > SmSymbolManager::GetSymbolSetNames() const
 }
 
 
-const SymbolPtrVec_t SmSymbolManager::GetSymbolSet( const OUString& rSymbolSetName )
+SymbolPtrVec_t SmSymbolManager::GetSymbolSet( const OUString& rSymbolSetName )
 {
     SymbolPtrVec_t aRes;
     if (!rSymbolSetName.isEmpty())