New loplugin:external

...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2 files changed, 3 insertions, 3 deletions

diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index eea95ab3c490..279f99a5e734 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -126,7 +126,7 @@ const OUString& SmFontStyles::GetStyleName( sal_uInt16 nIdx ) const
     }
 }
 
-const SmFontStyles & GetFontStyles()
+static const SmFontStyles & GetFontStyles()
 {
     static const SmFontStyles aImpl;
     return aImpl;
diff --git a/starmath/source/mathmlattr.cxx b/starmath/source/mathmlattr.cxx
index 344c079b35e9..a65e8d3f9a36 100644
--- a/starmath/source/mathmlattr.cxx
+++ b/starmath/source/mathmlattr.cxx
@@ -12,7 +12,7 @@
 #include <cassert>
 #include <unordered_map>
 
-sal_Int32 ParseMathMLUnsignedNumber(const OUString &rStr, Fraction& rUN)
+static sal_Int32 ParseMathMLUnsignedNumber(const OUString &rStr, Fraction& rUN)
 {
     auto nLen = rStr.getLength();
     sal_Int32 nDecimalPoint = -1;
@@ -38,7 +38,7 @@ sal_Int32 ParseMathMLUnsignedNumber(const OUString &rStr, Fraction& rUN)
     return nIdx;
 }
 
-sal_Int32 ParseMathMLNumber(const OUString &rStr, Fraction& rN)
+static sal_Int32 ParseMathMLNumber(const OUString &rStr, Fraction& rN)
 {
     if (rStr.isEmpty())
         return -1;