diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-11-02 18:59:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-11-03 17:11:14 +0100 |
| commit | ab285c743afa1c8769581871d7b56374fd8c49f1 (patch) | |
| tree | d5628df49fb4db29d474e5e7b7cef4072c33153a /starmath | |
| parent | f4544f3903fed3a656e3cd57e1bd83582e024b96 (diff) | |
loplugin:stringadd
tweak the plugin to be more permissive, then validate by hand
afterwards
Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654
Reviewed-on: https://gerrit.libreoffice.org/81942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'starmath')
| -rw-r--r-- | starmath/source/cfgitem.cxx | 4 | ||||
| -rw-r--r-- | starmath/source/cursor.cxx | 4 | ||||
| -rw-r--r-- | starmath/source/symbol.cxx | 7 |
3 files changed, 6 insertions, 9 deletions
diff --git a/starmath/source/cfgitem.cxx b/starmath/source/cfgitem.cxx index 76917500dee0..f3c0ec3e99b8 100644 --- a/starmath/source/cfgitem.cxx +++ b/starmath/source/cfgitem.cxx @@ -501,9 +501,9 @@ void SmMathConfig::SetSymbols( const std::vector< SmSym > &rNewSymbols ) for (const SmSym& rSymbol : rNewSymbols) { OUString aNodeNameDelim = SYMBOL_LIST + + aDelim + + rSymbol.GetExportName() + aDelim; - aNodeNameDelim += rSymbol.GetExportName(); - aNodeNameDelim += aDelim; const OUString *pName = pNames; diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx index c7a1ba31e90e..2aae7adb555e 100644 --- a/starmath/source/cursor.cxx +++ b/starmath/source/cursor.cxx @@ -393,9 +393,7 @@ SmCaretPos SmCursor::PatchLineList(SmNodeList* pLineList, SmNodeList::iterator a SmTextNode *pText = static_cast<SmTextNode*>(prev), *pOldN = static_cast<SmTextNode*>(next); SmCaretPos retval(pText, pText->GetText().getLength()); - OUString newText; - newText += pText->GetText(); - newText += pOldN->GetText(); + OUString newText = pText->GetText() + pOldN->GetText(); pText->ChangeText(newText); delete pOldN; pLineList->erase(aIter); diff --git a/starmath/source/symbol.cxx b/starmath/source/symbol.cxx index 63f20c006263..5e6a6486a337 100644 --- a/starmath/source/symbol.cxx +++ b/starmath/source/symbol.cxx @@ -237,8 +237,7 @@ void SmSymbolManager::Load() vcl::Font aFont( rSym.GetFace() ); OSL_ENSURE( aFont.GetItalic() == ITALIC_NONE, "expected Font with ITALIC_NONE, failed." ); aFont.SetItalic( ITALIC_NORMAL ); - OUString aSymbolName('i'); - aSymbolName += rSym.GetName(); + OUString aSymbolName = "i" + rSym.GetName(); SmSym aSymbol( aSymbolName, aFont, rSym.GetCharacter(), aSymbolSetName, true /*bIsPredefined*/ ); @@ -254,8 +253,8 @@ void SmSymbolManager::Save() SmMathConfig &rCfg = *SM_MOD()->GetConfig(); // prepare to skip symbols from iGreek on saving - OUString aSymbolSetName('i'); - aSymbolSetName += SmLocalizedSymbolData::GetUiSymbolSetName("Greek"); + OUString aSymbolSetName = "i" + + SmLocalizedSymbolData::GetUiSymbolSetName("Greek"); SymbolPtrVec_t aTmp( GetSymbols() ); std::vector< SmSym > aSymbols; |