diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-05-10 16:42:16 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-05-10 16:42:16 +0200 |
| commit | 14cd5182c5f64c43581c82db8c958369152226ac (patch) | |
| tree | 57f150ba2707f29214eeb9b1eaad2373780d1b15 /starmath | |
| parent | e4bb2b4f4875c15bd68297b5be716edd6859841e (diff) | |
Replace fallthrough comments with new SAL_FALLTHROUGH macro
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
Diffstat (limited to 'starmath')
| -rw-r--r-- | starmath/source/mathtype.cxx | 4 | ||||
| -rw-r--r-- | starmath/source/parse.cxx | 2 | ||||
| -rw-r--r-- | starmath/source/view.cxx | 2 | ||||
| -rw-r--r-- | starmath/source/wordexportbase.cxx | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/starmath/source/mathtype.cxx b/starmath/source/mathtype.cxx index 86279585947b..d18ef6386445 100644 --- a/starmath/source/mathtype.cxx +++ b/starmath/source/mathtype.cxx @@ -2617,13 +2617,13 @@ void MathType::HandleOperator(SmNode *pNode,int nLevel) pS->WriteUChar( CHAR ); pS->WriteUChar( 0x86 ); pS->WriteUInt16( 0x222B ); - ///fall-through + SAL_FALLTHROUGH; case TIINT: case TLLINT: pS->WriteUChar( CHAR ); pS->WriteUChar( 0x86 ); pS->WriteUInt16( 0x222B ); - ///fall-through + SAL_FALLTHROUGH; case TINT: case TINTD: case TLINT: diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx index 55a3a8d59749..8ff4ab4a62c0 100644 --- a/starmath/source/parse.cxx +++ b/starmath/source/parse.cxx @@ -2107,7 +2107,7 @@ void SmParser::DoFunction() { case TFUNC: NextToken(); // skip "FUNC"-statement - // fall through + SAL_FALLTHROUGH; case TSIN : case TCOS : diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx index 0ada602fc3da..e9a6fc57860b 100644 --- a/starmath/source/view.cxx +++ b/starmath/source/view.cxx @@ -1908,7 +1908,7 @@ void SmViewShell::GetState(SfxItemSet &rSet) case SID_ATTR_ZOOM: rSet.Put(SvxZoomItem( SvxZoomType::PERCENT, aGraphic->GetZoom())); - /* no break here */ + SAL_FALLTHROUGH; case SID_ZOOMIN: case SID_ZOOMOUT: case SID_ZOOM_OPTIMAL: diff --git a/starmath/source/wordexportbase.cxx b/starmath/source/wordexportbase.cxx index 99420d8005f4..215a6c73769c 100644 --- a/starmath/source/wordexportbase.cxx +++ b/starmath/source/wordexportbase.cxx @@ -170,7 +170,7 @@ void SmWordExportBase::HandleMath(const SmNode* pNode, int nLevel) case TDIVIDEBY: case TACUTE: OSL_ASSERT(false); - // the above are handled elsewhere, e.g. when handling BINHOR + SAL_FALLTHROUGH; // the above are handled elsewhere, e.g. when handling BINHOR default: HandleText(pNode, nLevel); break; |