diff options
author | Noel Grandin <noel@peralex.com> | 2015-01-20 12:38:10 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-01-26 08:42:28 +0200 |
commit | b44cbb26efe1d0b0950b1e1613e131b506dc3876 (patch) | |
tree | 9b4d5d99e5dad0971079b997a02a6d96536709ca /starmath | |
parent | 26ad60aec69310fecd918f1c2e09056aa4782320 (diff) |
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
Diffstat (limited to 'starmath')
-rw-r--r-- | starmath/inc/document.hxx | 4 | ||||
-rw-r--r-- | starmath/inc/node.hxx | 4 | ||||
-rw-r--r-- | starmath/inc/view.hxx | 6 |
3 files changed, 7 insertions, 7 deletions
diff --git a/starmath/inc/document.hxx b/starmath/inc/document.hxx index 792bbb68b4f1..5d1479395601 100644 --- a/starmath/inc/document.hxx +++ b/starmath/inc/document.hxx @@ -124,7 +124,7 @@ class SM_DLLPUBLIC SmDocShell : public SfxObjectShell, public SfxListener sal_Int32 nFileFormat, bool bTemplate = false ) const SAL_OVERRIDE; - virtual bool SetData( const OUString& rData ); + bool SetData( const OUString& rData ); virtual sal_uLong GetMiscStatus() const SAL_OVERRIDE; virtual void OnDocumentPrinterChanged( Printer * ) SAL_OVERRIDE; virtual bool InitNew( const ::com::sun::star::uno::Reference< ::com::sun::star::embed::XStorage >& xStorage ) SAL_OVERRIDE; @@ -209,7 +209,7 @@ public: virtual ::svl::IUndoManager *GetUndoManager () SAL_OVERRIDE; - virtual SfxItemPool& GetPool() const; + SfxItemPool& GetPool() const; void Execute( SfxRequest& rReq ); void GetState(SfxItemSet &); diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx index a44ed3596c57..9a3516c57837 100644 --- a/starmath/inc/node.hxx +++ b/starmath/inc/node.hxx @@ -147,7 +147,7 @@ public: void SetSize(const Fraction &rScale); virtual void Prepare(const SmFormat &rFormat, const SmDocShell &rDocShell); - virtual void PrepareAttributes(); + void PrepareAttributes(); sal_uInt16 FindIndex() const; @@ -161,7 +161,7 @@ public: const SmRect & GetRect() const { return *this; } SmRect & GetRect() { return *this; } - virtual void Move(const Point &rPosition); + void Move(const Point &rPosition); void MoveTo(const Point &rPosition) { Move(rPosition - GetTopLeft()); } virtual void Arrange(const OutputDevice &rDev, const SmFormat &rFormat); virtual void CreateTextFromNode(OUString &rText); diff --git a/starmath/inc/view.hxx b/starmath/inc/view.hxx index fa09ba35b791..0d9430e91e95 100644 --- a/starmath/inc/view.hxx +++ b/starmath/inc/view.hxx @@ -260,7 +260,7 @@ protected: const OUString& rText, sal_uInt16 MaxWidth); - virtual sal_uInt16 Print(SfxProgress &rProgress, bool bIsAPI); + sal_uInt16 Print(SfxProgress &rProgress, bool bIsAPI); virtual SfxPrinter *GetPrinter(bool bCreate = false) SAL_OVERRIDE; virtual sal_uInt16 SetPrinter(SfxPrinter *pNewPrinter, sal_uInt16 nDiffFlags = SFX_PRINTER_ALL, bool bIsAPI=false) SAL_OVERRIDE; @@ -308,8 +308,8 @@ private: static void InitInterface_Impl(); public: - virtual void Execute( SfxRequest& rReq ); - virtual void GetState(SfxItemSet &); + void Execute( SfxRequest& rReq ); + void GetState(SfxItemSet &); void Impl_Print( OutputDevice &rOutDev, const SmPrintUIOptions &rPrintUIOptions, Rectangle aOutRect, Point aZeroPoint ); |