starmath: Arabic text should always be upright

Change-Id: Ibe9f3092432ae4ffd81903df8672daf90947000c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157349
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>

1 files changed, 17 insertions, 1 deletions

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 695e1b4e3a8c..1a89b52c4110 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -1868,8 +1868,24 @@ void SmTextNode::Prepare(const SmFormat &rFormat, const SmDocShell &rDocShell, i
     // special handling for ':' where it is a token on its own and is likely
     // to be used for mathematical notations. (E.g. a:b = 2:3)
     // In that case it should not be displayed in italic.
-    if (GetToken().aText.getLength() == 1 && GetToken().aText[0] == ':')
+    if (maText.getLength() == 1 && GetToken().aText[0] == ':')
         Attributes() &= ~FontAttribute::Italic;
+
+    // Arabic text should not be italic, so we check for any charcter in Arabic script and
+    // remove italic attribute.
+    if (!maText.isEmpty())
+    {
+        sal_Int32 nIndex = 0;
+        while (nIndex < maText.getLength())
+        {
+            sal_uInt32 cChar = maText.iterateCodePoints(&nIndex);
+            if (u_getIntPropertyValue(cChar, UCHAR_SCRIPT) == USCRIPT_ARABIC)
+            {
+                Attributes() &= ~FontAttribute::Italic;
+                break;
+            }
+        }
+    }
 };