loplugin:bufferadd loosen some constraints

and extend O*StringView to have a constructor that takes a pointer and a
length

Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8
Reviewed-on: https://gerrit.libreoffice.org/80872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 4 insertions, 10 deletions

diff --git a/stoc/source/security/file_policy.cxx b/stoc/source/security/file_policy.cxx
index 9d8edc2bf102..08d97cfdbf44 100644
--- a/stoc/source/security/file_policy.cxx
+++ b/stoc/source/security/file_policy.cxx
@@ -172,11 +172,8 @@ void PolicyReader::assureToken( sal_Unicode token )
     sal_Unicode c = get();
     if (c == token)
         return;
-    OUStringBuffer buf( 16 );
-    buf.append( "expected >" );
-    buf.append( c );
-    buf.append( "<!" );
-    error( buf.makeStringAndClear() );
+    OUString msg = "expected >" + OUStringLiteral1(c) + "<!";
+    error( msg );
 }
 
 OUString PolicyReader::assureQuotedToken()
diff --git a/stoc/source/security/permissions.cxx b/stoc/source/security/permissions.cxx
index ab70ac1e051b..9568602c1fb4 100644
--- a/stoc/source/security/permissions.cxx
+++ b/stoc/source/security/permissions.cxx
@@ -435,11 +435,8 @@ bool RuntimePermission::implies( Permission const & perm ) const
 
 OUString RuntimePermission::toString() const
 {
-    OUStringBuffer buf( 48 );
-    buf.append( "com.sun.star.security.RuntimePermission (name=\"" );
-    buf.append( m_name );
-    buf.append( "\")" );
-    return buf.makeStringAndClear();
+    return "com.sun.star.security.RuntimePermission (name=\"" +
+        m_name + "\")";
 }