diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-07-15 20:26:40 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-07-15 20:44:10 +0100 |
commit | 1a3eedccd3f2c207b274e589c509975d3859f8f8 (patch) | |
tree | 266e1182c5ac07655f1c908cd04589a79f3d839d /stoc | |
parent | dc71a72753202d29544845cfd58992bac63c6837 (diff) |
cppcheck: noExplicitConstructor
Change-Id: Ia86c6a2ce6c1f2501d0b18181966b61d9ef78746
Diffstat (limited to 'stoc')
-rw-r--r-- | stoc/source/corereflection/base.hxx | 2 | ||||
-rw-r--r-- | stoc/source/implementationregistration/implreg.cxx | 2 | ||||
-rw-r--r-- | stoc/source/inspect/introspection.cxx | 2 | ||||
-rw-r--r-- | stoc/source/invocation/invocation.cxx | 2 | ||||
-rw-r--r-- | stoc/source/invocation_adapterfactory/iafactory.cxx | 2 | ||||
-rw-r--r-- | stoc/source/javaloader/javaloader.cxx | 2 | ||||
-rw-r--r-- | stoc/source/loader/dllcomponentloader.cxx | 2 | ||||
-rw-r--r-- | stoc/source/security/access_controller.cxx | 18 |
8 files changed, 14 insertions, 18 deletions
diff --git a/stoc/source/corereflection/base.hxx b/stoc/source/corereflection/base.hxx index 426c2d2c0c44..2b2793471945 100644 --- a/stoc/source/corereflection/base.hxx +++ b/stoc/source/corereflection/base.hxx @@ -111,7 +111,7 @@ public: uno_Interface * mapToUno( const css::uno::Any & rObj, typelib_InterfaceTypeDescription * pTo ) throw(css::uno::RuntimeException); // ctor/ dtor - IdlReflectionServiceImpl( const css::uno::Reference< css::uno::XComponentContext > & xContext ); + explicit IdlReflectionServiceImpl( const css::uno::Reference< css::uno::XComponentContext > & xContext ); virtual ~IdlReflectionServiceImpl(); // XInterface diff --git a/stoc/source/implementationregistration/implreg.cxx b/stoc/source/implementationregistration/implreg.cxx index e7d904ee83be..825723bad7a4 100644 --- a/stoc/source/implementationregistration/implreg.cxx +++ b/stoc/source/implementationregistration/implreg.cxx @@ -1199,7 +1199,7 @@ class ImplementationRegistration : public WeakImplHelper3< XImplementationRegistration2, XServiceInfo, XInitialization > { public: - ImplementationRegistration( const Reference < XComponentContext > & rSMgr ); + explicit ImplementationRegistration( const Reference < XComponentContext > & rSMgr ); virtual ~ImplementationRegistration(); // XServiceInfo diff --git a/stoc/source/inspect/introspection.cxx b/stoc/source/inspect/introspection.cxx index c92d6366ccf9..2b5f3d61c53c 100644 --- a/stoc/source/inspect/introspection.cxx +++ b/stoc/source/inspect/introspection.cxx @@ -233,7 +233,7 @@ class IntrospectionAccessStatic_Impl: public salhelper::SimpleReferenceObject sal_Int32 iNextIndex ); public: - IntrospectionAccessStatic_Impl( Reference< XIdlReflection > xCoreReflection_ ); + explicit IntrospectionAccessStatic_Impl( Reference< XIdlReflection > xCoreReflection_ ); virtual ~IntrospectionAccessStatic_Impl() { delete[] mpOrgPropertyHandleArray; diff --git a/stoc/source/invocation/invocation.cxx b/stoc/source/invocation/invocation.cxx index 8d195e965b88..ab31ab2b00e2 100644 --- a/stoc/source/invocation/invocation.cxx +++ b/stoc/source/invocation/invocation.cxx @@ -1051,7 +1051,7 @@ class InvocationService : public WeakImplHelper2< XSingleServiceFactory, XServiceInfo > { public: - InvocationService( const Reference<XComponentContext> & xCtx ); + explicit InvocationService( const Reference<XComponentContext> & xCtx ); virtual ~InvocationService(); // XServiceInfo diff --git a/stoc/source/invocation_adapterfactory/iafactory.cxx b/stoc/source/invocation_adapterfactory/iafactory.cxx index dca1c9778919..447264c589a3 100644 --- a/stoc/source/invocation_adapterfactory/iafactory.cxx +++ b/stoc/source/invocation_adapterfactory/iafactory.cxx @@ -100,7 +100,7 @@ public: Mutex m_mutex; t_ptr_map m_receiver2adapters; - FactoryImpl( Reference< XComponentContext > const & xContext ); + explicit FactoryImpl( Reference< XComponentContext > const & xContext ); virtual ~FactoryImpl(); // XServiceInfo diff --git a/stoc/source/javaloader/javaloader.cxx b/stoc/source/javaloader/javaloader.cxx index ea09b30118c0..d9355d5a3c96 100644 --- a/stoc/source/javaloader/javaloader.cxx +++ b/stoc/source/javaloader/javaloader.cxx @@ -100,7 +100,7 @@ class JavaComponentLoader : public WeakImplHelper2<XImplementationLoader, XServi public: - JavaComponentLoader(const css::uno::Reference<XComponentContext> & xCtx) + explicit JavaComponentLoader(const css::uno::Reference<XComponentContext> & xCtx) throw(RuntimeException); virtual ~JavaComponentLoader() throw(); diff --git a/stoc/source/loader/dllcomponentloader.cxx b/stoc/source/loader/dllcomponentloader.cxx index 14f49426d559..bb99a997a187 100644 --- a/stoc/source/loader/dllcomponentloader.cxx +++ b/stoc/source/loader/dllcomponentloader.cxx @@ -58,7 +58,7 @@ class DllComponentLoader XServiceInfo > { public: - DllComponentLoader( const Reference<XComponentContext> & xCtx ); + explicit DllComponentLoader( const Reference<XComponentContext> & xCtx ); virtual ~DllComponentLoader(); // XServiceInfo diff --git a/stoc/source/security/access_controller.cxx b/stoc/source/security/access_controller.cxx index c59153ff6ee9..fd709b196896 100644 --- a/stoc/source/security/access_controller.cxx +++ b/stoc/source/security/access_controller.cxx @@ -188,8 +188,11 @@ class acc_Policy PermissionCollection m_permissions; public: - inline acc_Policy( - PermissionCollection const & permissions ); + explicit acc_Policy( + PermissionCollection const & permissions ) + : m_permissions( permissions ) + {} + virtual ~acc_Policy(); // XAccessControlContext impl @@ -198,11 +201,6 @@ public: throw (RuntimeException, std::exception) SAL_OVERRIDE; }; -inline acc_Policy::acc_Policy( - PermissionCollection const & permissions ) - : m_permissions( permissions ) -{} - acc_Policy::~acc_Policy() {} @@ -292,14 +290,12 @@ class cc_reset { void * m_cc; public: - inline cc_reset( void * cc ) + explicit cc_reset( void * cc ) : m_cc( cc ) {} inline ~cc_reset() { ::uno_setCurrentContext( m_cc, s_envType.pData, 0 ); } }; - - struct MutexHolder { Mutex m_mutex; @@ -343,7 +339,7 @@ protected: virtual void SAL_CALL disposing() SAL_OVERRIDE; public: - AccessController( Reference< XComponentContext > const & xComponentContext ); + explicit AccessController( Reference< XComponentContext > const & xComponentContext ); virtual ~AccessController(); // XInitialization impl |