summaryrefslogtreecommitdiff
path: root/store
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@collabora.com>2020-09-04 15:51:07 +0200
committerLuboš Luňák <l.lunak@collabora.com>2020-09-10 11:15:47 +0200
commit4f36f2ccab6286ec09480caea602c0fa19195736 (patch)
tree0d3156c2f322983fa30d3a6f4600be5102e2718e /store
parent3f620e74aa00e34f773d97e9480a6532d9e8863e (diff)
detect if a cell still needs interpreting after Interpret()
https://bugs.documentfoundation.org/attachment.cgi?id=51878 after hard-recalc asserts because of not having cell dependencies non-dirty for threaded calculation. This is because Interpret() actually sometimes returns without computing a value for the cell, e.g. when it backs out because of a need to do iteration. This is handled when Interpret() is called from InterpretTail(), but ScDependantsCalculator does not handle this and considers all cells interpreted, unless it detected a problem. We've already fixed a number of such bugs, and given that there are still problematic corner cases after all this time, add code simply detecting this generic problem and avoiding threading in that case, with a SAL_WARN. This does not fix the problem itself, but at least now it's handled. Change-Id: I2f454b577f6516d2ce008005dbfbeb554e18d811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102156 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'store')
0 files changed, 0 insertions, 0 deletions