diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-14 17:14:18 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-11 11:38:15 +0200 |
| commit | 1f08bff31238d5818c54a0b86570689644dff087 (patch) | |
| tree | d4d6f4b62a3c48ddeb85ba89818247c17f2578c8 /store | |
| parent | ff130af9661a57d290dbf89b54a4c0ce8d0f71ea (diff) | |
new loplugin:shouldreturnbool
look for methods returning only 1 and/or 0, which (most of the time)
should be returning bool.
Off by default, because some of this is a matter of taste
Change-Id: Ib17782e629888255196e89d4a178618a9612a0de
Reviewed-on: https://gerrit.libreoffice.org/54379
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'store')
| -rw-r--r-- | store/source/storbios.cxx | 3 | ||||
| -rw-r--r-- | store/source/storbios.hxx | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/store/source/storbios.cxx b/store/source/storbios.cxx index 1a34da60d420..fad48695797d 100644 --- a/store/source/storbios.cxx +++ b/store/source/storbios.cxx @@ -396,13 +396,12 @@ OStorePageBIOS::Ace::~Ace() m_prev->m_next = m_next; } -int +void SAL_CALL OStorePageBIOS::Ace::constructor ( void * obj, SAL_UNUSED_PARAMETER void * /* arg */) { Ace * ace = static_cast<Ace*>(obj); ace->m_next = ace->m_prev = ace; - return 1; } OStorePageBIOS::Ace * diff --git a/store/source/storbios.hxx b/store/source/storbios.hxx index 8c2abd54f5a7..fafb54e79fed 100644 --- a/store/source/storbios.hxx +++ b/store/source/storbios.hxx @@ -141,7 +141,7 @@ public: Ace(); ~Ace(); - static int SAL_CALL constructor (void * obj, void * arg); + static void SAL_CALL constructor (void * obj, void * arg); static Ace * find (Ace * head, sal_uInt32 addr); static void insert (Ace * head, Ace * entry); |