diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-02 10:40:26 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-03 10:51:57 +0200 |
| commit | 054c0e7177cbef26942f8ca7cb7b1422ceea721c (patch) | |
| tree | 7390a1be5ee0797b7f43d7d433822315fd75c6dd /store | |
| parent | 0f499af8c2c22ccc8f1c19edeeb2bdac8cbcb7f0 (diff) | |
loplugin:simplifypointertobool improve
to look for the
x.get() != null
pattern, which can be simplified to
x
I'll do the
x.get() == nullptr
pattern in a separate patch, to reduce the chances of a mistake
Change-Id: I45e0d178e75359857cdf50d712039cb526016555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'store')
| -rw-r--r-- | store/source/storbase.hxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/store/source/storbase.hxx b/store/source/storbase.hxx index a5245de7380e..7829ae1c4a79 100644 --- a/store/source/storbase.hxx +++ b/store/source/storbase.hxx @@ -423,7 +423,7 @@ public: std::shared_ptr<PageData> tmp (rxAllocator->construct<T>(), PageData::Deallocate(rxAllocator)); m_xPage.swap (tmp); } - return (m_xPage.get() != nullptr); + return bool(m_xPage); } explicit PageHolderObject (std::shared_ptr<PageData> const & rxPage = std::shared_ptr<PageData>()) @@ -448,7 +448,7 @@ public: bool is() const { - return (m_xPage.get() != nullptr); + return bool(m_xPage); } std::shared_ptr<PageData> & get() { return m_xPage; } |