diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:09:01 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:19:22 +0200 |
| commit | 91dd2db17bd6cb9b357d1d69b187174e31eabef0 (patch) | |
| tree | d634de3a1a6820904b5699c2136b79b1a5a807c7 /svl/qa | |
| parent | 6f8ea7e89ea190b9462c945d55a3ad8777b2f3ef (diff) | |
loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
Diffstat (limited to 'svl/qa')
| -rw-r--r-- | svl/qa/unit/items/test_itempool.cxx | 2 | ||||
| -rw-r--r-- | svl/qa/unit/svl.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/svl/qa/unit/items/test_itempool.cxx b/svl/qa/unit/items/test_itempool.cxx index bf52772e763a..9a4aae2ba622 100644 --- a/svl/qa/unit/items/test_itempool.cxx +++ b/svl/qa/unit/items/test_itempool.cxx @@ -19,7 +19,7 @@ class PoolItemTest : public CppUnit::TestFixture { public: PoolItemTest() {} - virtual ~PoolItemTest() {} + virtual ~PoolItemTest() override {} void testPool(); diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx index 321e382ae6fd..e3a81fb7d1af 100644 --- a/svl/qa/unit/svl.cxx +++ b/svl/qa/unit/svl.cxx @@ -50,7 +50,7 @@ namespace { class Test : public CppUnit::TestFixture { public: Test(); - virtual ~Test(); + virtual ~Test() override; virtual void tearDown() override; |