diff options
| author | Noel Grandin <noel@peralex.com> | 2016-03-09 09:47:35 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-03-09 09:46:53 +0000 |
| commit | c8a93253e43e81e5dbc89937f2a21ca75e0582bc (patch) | |
| tree | c5ebf27b0f2a5ece4846bf2e0cd0a09815f105e0 /svl/qa | |
| parent | 9885a4f10f6b900a2a870e5fe691c4a465522b75 (diff) | |
remove unused NOT_POOLABLE enum value
and simplify the resulting SfxItemInfo field down to a single bool
Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2
Reviewed-on: https://gerrit.libreoffice.org/23058
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'svl/qa')
| -rw-r--r-- | svl/qa/unit/items/test_itempool.cxx | 19 |
1 files changed, 4 insertions, 15 deletions
diff --git a/svl/qa/unit/items/test_itempool.cxx b/svl/qa/unit/items/test_itempool.cxx index 0c817ec804be..cc43694493e4 100644 --- a/svl/qa/unit/items/test_itempool.cxx +++ b/svl/qa/unit/items/test_itempool.cxx @@ -35,10 +35,10 @@ class PoolItemTest : public CppUnit::TestFixture void PoolItemTest::testPool() { SfxItemInfo aItems[] = - { { 0, SfxItemPoolFlags::POOLABLE }, - { 1, SfxItemPoolFlags::NONE /* not poolable */ }, - { 2, SfxItemPoolFlags::NOT_POOLABLE }, - { 3, SfxItemPoolFlags::NONE /* not poolable */} + { { 0, true }, + { 1, false /* not poolable */ }, + { 2, false }, + { 3, false /* not poolable */} }; SfxItemPool *pPool = new SfxItemPool("testpool", 0, 3, aItems); @@ -80,17 +80,6 @@ void PoolItemTest::testPool() CPPUNIT_ASSERT(&rVal2 != &rVal); } - // not-poolable - SfxVoidItem aItemTwo( 2 ); - SfxVoidItem aNotherTwo( 2 ); - { - CPPUNIT_ASSERT(pImpl->maPoolItems[2] == nullptr); - const SfxPoolItem &rVal = pPool->Put(aItemTwo); - // those guys just don't go in ... - CPPUNIT_ASSERT(pImpl->maPoolItems[2] == nullptr); - CPPUNIT_ASSERT(rVal == aItemOne); - } - // Test rehash for (size_t i = 0; i < pImpl->maPoolItems.size(); ++i) { |