diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 09:07:25 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 23:42:26 +0000 |
commit | 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 (patch) | |
tree | f8b8cea0a81bc74ca34e8bda2d0dfce939b28ce0 /svl/source/items | |
parent | 20deac4903fc0697477e855feeff482b3da234f9 (diff) |
callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
Diffstat (limited to 'svl/source/items')
-rw-r--r-- | svl/source/items/cintitem.cxx | 72 | ||||
-rw-r--r-- | svl/source/items/intitem.cxx | 18 | ||||
-rw-r--r-- | svl/source/items/style.cxx | 17 |
3 files changed, 0 insertions, 107 deletions
diff --git a/svl/source/items/cintitem.cxx b/svl/source/items/cintitem.cxx index 7399633c6b87..0fde0d94003e 100644 --- a/svl/source/items/cintitem.cxx +++ b/svl/source/items/cintitem.cxx @@ -96,24 +96,6 @@ SfxPoolItem * CntByteItem::Clone(SfxItemPool *) const return new CntByteItem(*this); } -// virtual -sal_uInt8 CntByteItem::GetMin() const -{ - return 0; -} - -// virtual -sal_uInt8 CntByteItem::GetMax() const -{ - return 255; -} - -// virtual -SfxFieldUnit CntByteItem::GetUnit() const -{ - return SFX_FUNIT_NONE; -} - TYPEINIT1_AUTOFACTORY(CntUInt16Item, SfxPoolItem); CntUInt16Item::CntUInt16Item(sal_uInt16 which, SvStream & rStream) : @@ -199,24 +181,6 @@ SfxPoolItem * CntUInt16Item::Clone(SfxItemPool *) const return new CntUInt16Item(*this); } -// virtual -sal_uInt16 CntUInt16Item::GetMin() const -{ - return 0; -} - -// virtual -sal_uInt16 CntUInt16Item::GetMax() const -{ - return 65535; -} - -// virtual -SfxFieldUnit CntUInt16Item::GetUnit() const -{ - return SFX_FUNIT_NONE; -} - TYPEINIT1_AUTOFACTORY(CntInt32Item, SfxPoolItem); CntInt32Item::CntInt32Item(sal_uInt16 which, SvStream & rStream) @@ -298,24 +262,6 @@ SfxPoolItem * CntInt32Item::Clone(SfxItemPool *) const return new CntInt32Item(*this); } -// virtual -sal_Int32 CntInt32Item::GetMin() const -{ - return sal_Int32(0x80000000); -} - -// virtual -sal_Int32 CntInt32Item::GetMax() const -{ - return 0x7FFFFFFF; -} - -// virtual -SfxFieldUnit CntInt32Item::GetUnit() const -{ - return SFX_FUNIT_NONE; -} - TYPEINIT1_AUTOFACTORY(CntUInt32Item, SfxPoolItem); CntUInt32Item::CntUInt32Item(sal_uInt16 which, SvStream & rStream) : @@ -402,22 +348,4 @@ SfxPoolItem * CntUInt32Item::Clone(SfxItemPool *) const return new CntUInt32Item(*this); } -// virtual -sal_uInt32 CntUInt32Item::GetMin() const -{ - return 0; -} - -// virtual -sal_uInt32 CntUInt32Item::GetMax() const -{ - return 0xFFFFFFFF; -} - -// virtual -SfxFieldUnit CntUInt32Item::GetUnit() const -{ - return SFX_FUNIT_NONE; -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/svl/source/items/intitem.cxx b/svl/source/items/intitem.cxx index a9405d7daf5a..e596d4a5a8f9 100644 --- a/svl/source/items/intitem.cxx +++ b/svl/source/items/intitem.cxx @@ -121,25 +121,7 @@ SfxPoolItem * SfxInt16Item::Clone(SfxItemPool *) const return new SfxInt16Item(*this); } -sal_Int16 SfxInt16Item::GetMin() const -{ - return -32768; -} - -sal_Int16 SfxInt16Item::GetMax() const -{ - return 32767; -} - -SfxFieldUnit SfxInt16Item::GetUnit() const -{ - return SFX_FUNIT_NONE; -} - - // class SfxUInt16Item - - TYPEINIT1_AUTOFACTORY(SfxUInt16Item, CntUInt16Item); void SfxUInt16Item::dumpAsXml(xmlTextWriterPtr pWriter) const diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx index cddf81b31193..e75c0056d1dc 100644 --- a/svl/source/items/style.cxx +++ b/svl/source/items/style.cxx @@ -151,13 +151,7 @@ SfxStyleSheetBase::~SfxStyleSheetBase() } } -sal_uInt16 SfxStyleSheetBase::GetVersion() const -{ - return 0x0000; -} - // Change name - const OUString& SfxStyleSheetBase::GetName() const { return aName; @@ -207,13 +201,7 @@ OUString SfxStyleSheetBase::GetDisplayName() const } } -void SfxStyleSheetBase::SetDisplayName( const OUString& rDisplayName ) -{ - maDisplayName = rDisplayName; -} - // Change Parent - const OUString& SfxStyleSheetBase::GetParent() const { return aParent; @@ -957,11 +945,6 @@ SfxStyleSheetBase* SfxStyleSheetPool::Create( const OUString& rName, return new SfxStyleSheet( rName, *this, eFam, mask ); } -SfxStyleSheetBase* SfxStyleSheetPool::Create( const SfxStyleSheet& r ) -{ - return new SfxStyleSheet( r ); -} - SfxUnoStyleSheet::SfxUnoStyleSheet( const OUString& _rName, const SfxStyleSheetBasePool& _rPool, SfxStyleFamily _eFamily, sal_uInt16 _nMaske ) : ::cppu::ImplInheritanceHelper2< SfxStyleSheet, ::com::sun::star::style::XStyle, ::com::sun::star::lang::XUnoTunnel >( _rName, _rPool, _eFamily, _nMaske ) { |