update unusedmethods plugin to deal with constructors

and fix the operator< implementations in some of the other
plugins too.

Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae)

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035

5 files changed, 1 insertions, 48 deletions

diff --git a/svl/source/items/ctypeitm.cxx b/svl/source/items/ctypeitm.cxx
index ae559c3affad..587b6a04dbbc 100644
--- a/svl/source/items/ctypeitm.cxx
+++ b/svl/source/items/ctypeitm.cxx
@@ -36,12 +36,6 @@
 
 #define CONTENT_TYPE_NOT_INIT ( (INetContentType)-1 )
 
-CntContentTypeItem::CntContentTypeItem()
-: CntUnencodedStringItem(),
-  _eType( CONTENT_TYPE_NOT_INIT )
-{
-}
-
 CntContentTypeItem::CntContentTypeItem( sal_uInt16 which, const OUString& rType )
 : CntUnencodedStringItem( which, rType ),
   _eType( CONTENT_TYPE_NOT_INIT )
diff --git a/svl/source/items/nranges.cxx b/svl/source/items/nranges.cxx
index bc8990eb53d8..ff9ff7d6e3ab 100644
--- a/svl/source/items/nranges.cxx
+++ b/svl/source/items/nranges.cxx
@@ -155,7 +155,7 @@ SfxUShortRanges::SfxUShortRanges( sal_uInt16 nWhich1, sal_uInt16 nWhich2 )
 }
 
 /**
- * Constcurts an SfxUShortRanges-instance from an sorted ranges of sal_uInt16s,
+ * Constructs an SfxUShortRanges-instance from an sorted ranges of sal_uInt16s,
  * terminates with on 0.
  *
  * Precondition: for each n >= 0 && n < (sizeof(pArr)-1)
diff --git a/svl/source/items/rngitem.cxx b/svl/source/items/rngitem.cxx
index a1205894aee1..6fcd15738c21 100644
--- a/svl/source/items/rngitem.cxx
+++ b/svl/source/items/rngitem.cxx
@@ -31,8 +31,6 @@ static inline sal_uInt16 Count_Impl(const sal_uInt16 * pRanges)
 }
 
 
-
-
 SfxRangeItem::SfxRangeItem()
 {
     nFrom = 0;
@@ -40,7 +38,6 @@ SfxRangeItem::SfxRangeItem()
 }
 
 
-
 SfxRangeItem::SfxRangeItem( sal_uInt16 which, sal_uInt16 from, sal_uInt16 to ):
     SfxPoolItem( which ),
     nFrom( from ),
@@ -49,7 +46,6 @@ SfxRangeItem::SfxRangeItem( sal_uInt16 which, sal_uInt16 from, sal_uInt16 to ):
 }
 
 
-
 SfxRangeItem::SfxRangeItem( const SfxRangeItem& rItem ) :
     SfxPoolItem( rItem )
 {
@@ -58,7 +54,6 @@ SfxRangeItem::SfxRangeItem( const SfxRangeItem& rItem ) :
 }
 
 
-
 bool SfxRangeItem::GetPresentation
 (
     SfxItemPresentation     /*ePresentation*/,
@@ -73,7 +68,6 @@ bool SfxRangeItem::GetPresentation
 }
 
 
-
 bool SfxRangeItem::operator==( const SfxPoolItem& rItem ) const
 {
     DBG_ASSERT( SfxPoolItem::operator==( rItem ), "unequal type" );
@@ -82,14 +76,12 @@ bool SfxRangeItem::operator==( const SfxPoolItem& rItem ) const
 }
 
 
-
 SfxPoolItem* SfxRangeItem::Clone(SfxItemPool *) const
 {
     return new SfxRangeItem( Which(), nFrom, nTo );
 }
 
 
-
 SfxPoolItem* SfxRangeItem::Create(SvStream &rStream, sal_uInt16) const
 {
     sal_uInt16 nVon(0), nBis(0);
@@ -99,7 +91,6 @@ SfxPoolItem* SfxRangeItem::Create(SvStream &rStream, sal_uInt16) const
 }
 
 
-
 SvStream& SfxRangeItem::Store(SvStream &rStream, sal_uInt16) const
 {
     rStream.WriteUInt16( nFrom );
diff --git a/svl/source/items/szitem.cxx b/svl/source/items/szitem.cxx
index dffa4bdac26e..2239919691f8 100644
--- a/svl/source/items/szitem.cxx
+++ b/svl/source/items/szitem.cxx
@@ -28,14 +28,11 @@
 #include <svl/memberid.hrc>
 
 
-
-
 SfxSizeItem::SfxSizeItem()
 {
 }
 
 
-
 SfxSizeItem::SfxSizeItem( sal_uInt16 nW, const Size& rVal ) :
     SfxPoolItem( nW ),
     aVal( rVal )
@@ -43,7 +40,6 @@ SfxSizeItem::SfxSizeItem( sal_uInt16 nW, const Size& rVal ) :
 }
 
 
-
 SfxSizeItem::SfxSizeItem( const SfxSizeItem& rItem ) :
     SfxPoolItem( rItem ),
     aVal( rItem.aVal )
@@ -51,7 +47,6 @@ SfxSizeItem::SfxSizeItem( const SfxSizeItem& rItem ) :
 }
 
 
-
 bool SfxSizeItem::GetPresentation
 (
     SfxItemPresentation     /*ePresentation*/,
@@ -66,7 +61,6 @@ bool SfxSizeItem::GetPresentation
 }
 
 
-
 bool SfxSizeItem::operator==( const SfxPoolItem& rItem ) const
 {
     DBG_ASSERT( SfxPoolItem::operator==( rItem ), "unequal type" );
@@ -74,14 +68,12 @@ bool SfxSizeItem::operator==( const SfxPoolItem& rItem ) const
 }
 
 
-
 SfxPoolItem* SfxSizeItem::Clone(SfxItemPool *) const
 {
     return new SfxSizeItem( *this );
 }
 
 
-
 SfxPoolItem* SfxSizeItem::Create(SvStream &rStream, sal_uInt16 ) const
 {
     Size aStr;
@@ -90,7 +82,6 @@ SfxPoolItem* SfxSizeItem::Create(SvStream &rStream, sal_uInt16 ) const
 }
 
 
-
 SvStream& SfxSizeItem::Store(SvStream &rStream, sal_uInt16 ) const
 {
     WritePair( rStream, aVal );
@@ -171,5 +162,4 @@ bool SfxSizeItem::PutValue( const css::uno::Any& rVal,
 }
 
 
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svl/source/svdde/ddecli.cxx b/svl/source/svdde/ddecli.cxx
index ada0d241be30..f3563a36b271 100644
--- a/svl/source/svdde/ddecli.cxx
+++ b/svl/source/svdde/ddecli.cxx
@@ -367,34 +367,12 @@ DdeRequest::DdeRequest( DdeConnection& d, const OUString& i, long n )
     nType = XTYP_REQUEST;
 }
 
-DdeWarmLink::DdeWarmLink( DdeConnection& d, const OUString& i, long n )
-    : DdeLink( d, i, n )
-{
-    nType = XTYP_ADVSTART | XTYPF_NODATA;
-}
-
 DdeHotLink::DdeHotLink( DdeConnection& d, const OUString& i, long n )
     : DdeLink( d, i, n )
 {
     nType = XTYP_ADVSTART;
 }
 
-DdePoke::DdePoke( DdeConnection& d, const OUString& i, const char* p,
-                  long l, SotClipboardFormatId f, long n )
-    : DdeTransaction( d, i, n )
-{
-    aDdeData = DdeData( p, l, f );
-    nType = XTYP_POKE;
-}
-
-DdePoke::DdePoke( DdeConnection& d, const OUString& i, const OUString& rData,
-                  long n )
-    : DdeTransaction( d, i, n )
-{
-    aDdeData = DdeData( (void*) rData.getStr(), sizeof(sal_Unicode) * (rData.getLength()), SotClipboardFormatId::STRING );
-    nType = XTYP_POKE;
-}
-
 DdePoke::DdePoke( DdeConnection& d, const OUString& i, const DdeData& rData,
                   long n )
     : DdeTransaction( d, i, n )