tdf#163486: PVS: variable is used after being declared

V614 	The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
V614 	The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.

Change-Id: Ic84af8c395c4b3f86017eb83be17a6fbd628e5d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176553
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins

1 files changed, 2 insertions, 4 deletions

diff --git a/svl/source/items/stylepool.cxx b/svl/source/items/stylepool.cxx
index af7b9fb6e874..4d89fc680086 100644
--- a/svl/source/items/stylepool.cxx
+++ b/svl/source/items/stylepool.cxx
@@ -228,8 +228,7 @@ namespace {
             }
         }
 
-        std::shared_ptr<SfxItemSet> pReturn;
-        return pReturn;
+        return std::shared_ptr<SfxItemSet>();
     }
 
     class Iterator
@@ -285,7 +284,6 @@ namespace {
 
     std::shared_ptr<SfxItemSet> Iterator::getNext()
     {
-        std::shared_ptr<SfxItemSet> pReturn;
         while( mpNode || mpCurrParent != maParents.end() )
         {
             if( !mpNode )
@@ -315,7 +313,7 @@ namespace {
                 return mpNode->getItemSetOfIgnorableChild( mbSkipUnusedItemSets );
             }
         }
-        return pReturn;
+        return std::shared_ptr<SfxItemSet>();
     }
 
 }