diff options
author | Luboš Luňák <l.lunak@collabora.com> | 2022-02-20 12:38:29 +0100 |
---|---|---|
committer | Luboš Luňák <l.lunak@collabora.com> | 2022-02-20 20:46:41 +0100 |
commit | e81400196cd9c24be32552a19851da4162d51c7a (patch) | |
tree | 55d105a5f24823bc9aa07f12bbc70864a5e55b24 /svl | |
parent | 26603bc9ef0116ed31c510dab82b69d3666447b5 (diff) |
fix ScPatternAttr lookup hashing (tdf#135215)
I made a mistake in 98d51bf8ce13bdac2d71f50f58d6d0ddb by using
SfxItemSet::Count(), which returns a number of existing items.
But EqualPatternSets() compares all items, even empty ones,
so I should have used TotalCount() (which is actually hardcoded
as a number in the code). Without this, the hash usually didn't
include all items, leading to matching hashes even though
the items clearly didn't match.
Change-Id: I1e25752d3ddca2b63c3c295a9a425965531cd4d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130210
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'svl')
0 files changed, 0 insertions, 0 deletions