perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related

There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.

To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.

For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.

Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

5 files changed, 9 insertions, 9 deletions

diff --git a/svl/source/config/ctloptions.cxx b/svl/source/config/ctloptions.cxx
index 3c3fa2302e08..311a56a84fda 100644
--- a/svl/source/config/ctloptions.cxx
+++ b/svl/source/config/ctloptions.cxx
@@ -26,9 +26,9 @@
 #include <com/sun/star/uno/Any.h>
 #include <com/sun/star/uno/Sequence.hxx>
 #include <osl/mutex.hxx>
-#include <svl/smplhint.hxx>
 #include <rtl/instance.hxx>
 #include <unotools/syslocale.hxx>
+#include <svl/hint.hxx>
 #include "itemholder2.hxx"
 
 using namespace ::com::sun::star;
diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx
index 15333f2f1aff..fbf1281169b7 100644
--- a/svl/source/items/itempool.cxx
+++ b/svl/source/items/itempool.cxx
@@ -25,7 +25,7 @@
 #include <sal/log.hxx>
 #include "whassert.hxx"
 #include <svl/SfxBroadcaster.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include "poolio.hxx"
 
 #include <algorithm>
@@ -490,7 +490,7 @@ void SfxItemPool::Delete()
         return;
 
     // Inform e.g. running Requests
-    pImpl->aBC.Broadcast( SfxSimpleHint( SFX_HINT_DYING ) );
+    pImpl->aBC.Broadcast( SfxHint( SFX_HINT_DYING ) );
 
     // Iterate through twice: first for the SetItems.
     if (pImpl->ppStaticDefaults != nullptr) {
diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx
index c6cd0324249a..f4ab21c60f6e 100644
--- a/svl/source/items/style.cxx
+++ b/svl/source/items/style.cxx
@@ -26,7 +26,7 @@
 #include <osl/diagnose.h>
 #include <comphelper/processfactory.hxx>
 #include <unotools/intlwrapper.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include <svl/poolitem.hxx>
 #include <svl/itemset.hxx>
 #include <svl/itempool.hxx>
@@ -608,7 +608,7 @@ SfxStyleSheetBasePool::~SfxStyleSheetBasePool()
     aDbgStyleSheetReferences.mnPools--;
 #endif
 
-    Broadcast( SfxSimpleHint(SFX_HINT_DYING) );
+    Broadcast( SfxHint(SFX_HINT_DYING) );
     Clear();
 }
 
diff --git a/svl/source/notify/SfxBroadcaster.cxx b/svl/source/notify/SfxBroadcaster.cxx
index eaeed4dbee49..3b069b1989fc 100644
--- a/svl/source/notify/SfxBroadcaster.cxx
+++ b/svl/source/notify/SfxBroadcaster.cxx
@@ -20,7 +20,7 @@
 #include <svl/SfxBroadcaster.hxx>
 
 #include <svl/hint.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include <svl/lstner.hxx>
 #include <tools/debug.hxx>
 
@@ -55,7 +55,7 @@ void SfxBroadcaster::Broadcast( const SfxHint &rHint )
 
 SfxBroadcaster::~SfxBroadcaster()
 {
-    Broadcast( SfxSimpleHint(SFX_HINT_DYING) );
+    Broadcast( SfxHint(SFX_HINT_DYING) );
 
     // remove all still registered listeners
     for (size_t i = 0; i < mpImpl->m_Listeners.size(); ++i)
diff --git a/svl/source/notify/broadcast.cxx b/svl/source/notify/broadcast.cxx
index 2a9338ca787e..cd110e19e66e 100644
--- a/svl/source/notify/broadcast.cxx
+++ b/svl/source/notify/broadcast.cxx
@@ -19,7 +19,7 @@
 
 #include <svl/broadcast.hxx>
 #include <svl/listener.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include <algorithm>
 
 void SvtBroadcaster::Normalize() const
@@ -101,7 +101,7 @@ SvtBroadcaster::SvtBroadcaster( const SvtBroadcaster &rBC ) :
 SvtBroadcaster::~SvtBroadcaster()
 {
     mbDisposing = true;
-    Broadcast( SfxSimpleHint(SFX_HINT_DYING) );
+    Broadcast( SfxHint(SFX_HINT_DYING) );
 
     Normalize();