diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-06-15 10:47:51 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-06-15 14:17:13 +0200 |
commit | 964eb2f1dd24d68bd1d6caf8d0f349305a2642ec (patch) | |
tree | 6e588e61eb58a3ab4fe975e2725d7396ae2a509d /svl | |
parent | dc051857c36a2f1e27cf149c13bd0e199db60109 (diff) |
Revert "simplify SharedString::operator=(&&)"
This reverts commit 2da1cdd31312a70f205f29bb4dfcbc1771409aa4.
Comment from llunak:
I'm possibly not remembering it exactly. But the point is that if you're going to destroy something, it's faster to destroy it outright rather than move it somewhere and destroy it later. If you google it you'll find posts on how implementing std::move() using std:swap() is generally a pessimisation.
Change-Id: Ice4234ad074cd894a25782e9c52b34c5acb26c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135880
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svl')
0 files changed, 0 insertions, 0 deletions