diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-28 11:47:51 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-28 14:51:56 +0200 |
| commit | b09deb075319c1c19f91e3a6f64429b61682ebf8 (patch) | |
| tree | 9e73d1e63092083a337a4ddf1dfe962b4f6ef4dc /svl | |
| parent | 587d6e13df7bb9c8f78ce605ebb8f8fd34b85a2c (diff) | |
loplugin:constparams handle constructors
had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis
Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svl')
| -rw-r--r-- | svl/source/items/stylepool.cxx | 4 | ||||
| -rw-r--r-- | svl/source/numbers/numfmuno.cxx | 2 | ||||
| -rw-r--r-- | svl/source/numbers/numfmuno.hxx | 2 | ||||
| -rw-r--r-- | svl/source/numbers/zformat.cxx | 4 |
4 files changed, 6 insertions, 6 deletions
diff --git a/svl/source/items/stylepool.cxx b/svl/source/items/stylepool.cxx index cfc61ab4ed0e..15be4eb971ed 100644 --- a/svl/source/items/stylepool.cxx +++ b/svl/source/items/stylepool.cxx @@ -350,7 +350,7 @@ private: std::unique_ptr<SfxItemSet> mpIgnorableItems; public: // #i86923# - explicit StylePoolImpl( SfxItemSet* pIgnorableItems ) + explicit StylePoolImpl( SfxItemSet const * pIgnorableItems ) : maRoot(), mpIgnorableItems( pIgnorableItems != nullptr ? pIgnorableItems->Clone( false ) @@ -444,7 +444,7 @@ IStylePoolIteratorAccess* StylePoolImpl::createIterator( bool bSkipUnusedItemSet // Ctor, Dtor and redirected methods of class StylePool, nearly inline ;-) // #i86923# -StylePool::StylePool( SfxItemSet* pIgnorableItems ) +StylePool::StylePool( SfxItemSet const * pIgnorableItems ) : pImpl( new StylePoolImpl( pIgnorableItems ) ) {} diff --git a/svl/source/numbers/numfmuno.cxx b/svl/source/numbers/numfmuno.cxx index 9c014f06ccac..0ed49e83eeac 100644 --- a/svl/source/numbers/numfmuno.cxx +++ b/svl/source/numbers/numfmuno.cxx @@ -368,7 +368,7 @@ uno::Sequence<OUString> SAL_CALL SvNumberFormatterServiceObj::getSupportedServic return { "com.sun.star.util.NumberFormatter" }; } -SvNumberFormatsObj::SvNumberFormatsObj( SvNumberFormatsSupplierObj& _rParent, ::comphelper::SharedMutex& _rMutex ) +SvNumberFormatsObj::SvNumberFormatsObj( SvNumberFormatsSupplierObj& _rParent, ::comphelper::SharedMutex const & _rMutex ) :rSupplier( _rParent ) ,m_aMutex( _rMutex ) { diff --git a/svl/source/numbers/numfmuno.hxx b/svl/source/numbers/numfmuno.hxx index 01c582594694..3885e2d4a17f 100644 --- a/svl/source/numbers/numfmuno.hxx +++ b/svl/source/numbers/numfmuno.hxx @@ -91,7 +91,7 @@ private: mutable ::comphelper::SharedMutex m_aMutex; public: - SvNumberFormatsObj(SvNumberFormatsSupplierObj& pParent, ::comphelper::SharedMutex& _rMutex); + SvNumberFormatsObj(SvNumberFormatsSupplierObj& pParent, ::comphelper::SharedMutex const & _rMutex); virtual ~SvNumberFormatsObj() override; diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 224190550edd..d12c3624e610 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -407,13 +407,13 @@ void SvNumberformat::ImpCopyNumberformat( const SvNumberformat& rFormat ) } } -SvNumberformat::SvNumberformat( SvNumberformat& rFormat ) +SvNumberformat::SvNumberformat( SvNumberformat const & rFormat ) : rScan(rFormat.rScan), bStarFlag( rFormat.bStarFlag ) { ImpCopyNumberformat( rFormat ); } -SvNumberformat::SvNumberformat( SvNumberformat& rFormat, ImpSvNumberformatScan& rSc ) +SvNumberformat::SvNumberformat( SvNumberformat const & rFormat, ImpSvNumberformatScan& rSc ) : rScan(rSc) , bStarFlag( rFormat.bStarFlag ) { |