diff options
| author | Michael Stahl <mstahl@redhat.com> | 2015-03-11 16:39:24 +0100 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2015-03-11 16:50:03 +0100 |
| commit | 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba (patch) | |
| tree | 3959801825b12a5def0a4e6402917a455aa9c6a2 /svtools/source/config/miscopt.cxx | |
| parent | a7b9167235d38130aab1af4bed66b6c48d375fc9 (diff) | |
do not call virtual Commit() from dtors of utl::ConfigItem subclasses
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
Diffstat (limited to 'svtools/source/config/miscopt.cxx')
| -rw-r--r-- | svtools/source/config/miscopt.cxx | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/svtools/source/config/miscopt.cxx b/svtools/source/config/miscopt.cxx index 9d4fcaf2870f..0dd13809f899 100644 --- a/svtools/source/config/miscopt.cxx +++ b/svtools/source/config/miscopt.cxx @@ -386,11 +386,7 @@ SvtMiscOptions_Impl::SvtMiscOptions_Impl() SvtMiscOptions_Impl::~SvtMiscOptions_Impl() { - // We must save our current values .. if user forgets it! - if( IsModified() ) - { - Commit(); - } + assert(!IsModified()); // should have been committed } static int lcl_MapPropertyName( const OUString& rCompare, |