Replace fallthrough comments with new SAL_FALLTHROUGH macro

...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca

1 files changed, 3 insertions, 3 deletions

diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index f827dbfa2264..b2f58c2b0832 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1336,7 +1336,7 @@ void ValueSet::KeyInput( const KeyEvent& rKeyEvent )
                 return;
             }
             nVStep *= mnVisLines;
-            // intentional fall-through
+            SAL_FALLTHROUGH;
         case KEY_UP:
             if (nCurPos != VALUESET_ITEM_NONEITEM)
             {
@@ -1373,7 +1373,7 @@ void ValueSet::KeyInput( const KeyEvent& rKeyEvent )
                 return;
             }
             nVStep *= mnVisLines;
-            // intentional fall-through
+            SAL_FALLTHROUGH;
         case KEY_DOWN:
             if (nCurPos != nLastItem)
             {
@@ -1398,7 +1398,7 @@ void ValueSet::KeyInput( const KeyEvent& rKeyEvent )
                 Select();
                 break;
             }
-            // intentional fall-through
+            SAL_FALLTHROUGH;
         default:
             Control::KeyInput( rKeyEvent );
             return;