diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-06-17 08:22:00 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-06-18 08:06:33 +0200 |
| commit | 129e799e1acf25d7dcd7ccf0438896cc125e7653 (patch) | |
| tree | 7a04097e0a119bb56d68ad284c9ccb7e29d71898 /svtools/source/misc | |
| parent | 8a453f96f0181b1eae227ebdadea6ee458d53eb4 (diff) | |
loplugin:logexceptionnicely in svtools
Change-Id: I631f3750af2e9a26d0a034f5a22d5b0c2910325c
Reviewed-on: https://gerrit.libreoffice.org/74142
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svtools/source/misc')
| -rw-r--r-- | svtools/source/misc/embedhlp.cxx | 12 | ||||
| -rw-r--r-- | svtools/source/misc/imagemgr.cxx | 5 | ||||
| -rw-r--r-- | svtools/source/misc/langhelp.cxx | 5 |
3 files changed, 12 insertions, 10 deletions
diff --git a/svtools/source/misc/embedhlp.cxx b/svtools/source/misc/embedhlp.cxx index 55a65e513734..eace6d8e927a 100644 --- a/svtools/source/misc/embedhlp.cxx +++ b/svtools/source/misc/embedhlp.cxx @@ -341,9 +341,9 @@ void EmbeddedObjectRef::Clear() { // there's still someone who needs the object! } - catch (const uno::Exception& e) + catch (const uno::Exception&) { - SAL_WARN("svtools.misc", "Error on switching of the object to loaded state and closing: \"" << e << "\""); + TOOLS_WARN_EXCEPTION("svtools.misc", "Error on switching of the object to loaded state and closing"); } } } @@ -493,18 +493,18 @@ Size EmbeddedObjectRef::GetSize( MapMode const * pTargetMapMode ) const catch(const embed::NoVisualAreaSizeException&) { } - catch (const uno::Exception& e) + catch (const uno::Exception&) { - SAL_WARN("svtools.misc", "Something went wrong on getting of the size of the object: \"" << e << "\""); + TOOLS_WARN_EXCEPTION("svtools.misc", "Something went wrong on getting of the size of the object"); } try { aSourceMapMode = MapMode(VCLUnoHelper::UnoEmbed2VCLMapUnit(mpImpl->mxObj->getMapUnit(mpImpl->nViewAspect))); } - catch (const uno::Exception& e) + catch (const uno::Exception&) { - SAL_WARN("svtools.misc", "Can not get the map mode: \"" << e << "\""); + TOOLS_WARN_EXCEPTION("svtools.misc", "Can not get the map mode"); } } diff --git a/svtools/source/misc/imagemgr.cxx b/svtools/source/misc/imagemgr.cxx index e38760f829b0..e7eab73f2b54 100644 --- a/svtools/source/misc/imagemgr.cxx +++ b/svtools/source/misc/imagemgr.cxx @@ -18,6 +18,7 @@ */ #include <svtools/imagemgr.hxx> +#include <tools/diagnose_ex.h> #include <tools/urlobj.hxx> #include <tools/debug.hxx> #include <sal/log.hxx> @@ -392,9 +393,9 @@ static SvImageId GetImageId_Impl( const INetURLObject& rObject, bool bDetectFold nId = SvImageId::MathTemplate; } } - catch (const css::ucb::ContentCreationException& e) + catch (const css::ucb::ContentCreationException&) { - SAL_WARN("svtools.misc", "GetImageId_Impl: Caught " << e); + TOOLS_WARN_EXCEPTION("svtools.misc", "GetImageId_Impl"); } return nId; diff --git a/svtools/source/misc/langhelp.cxx b/svtools/source/misc/langhelp.cxx index 57d1d2f89ca3..6cedddca3f89 100644 --- a/svtools/source/misc/langhelp.cxx +++ b/svtools/source/misc/langhelp.cxx @@ -20,6 +20,7 @@ #include <rtl/ustring.hxx> #include <sal/log.hxx> #include <svtools/langhelp.hxx> +#include <tools/diagnose_ex.h> #include <vcl/idle.hxx> #include <vcl/svapp.hxx> #include <vcl/sysdata.hxx> @@ -97,9 +98,9 @@ public: css::uno::Reference<XSyncDbusSessionHelper> xSyncDbusSessionHelper(SyncDbusSessionHelper::create(comphelper::getProcessComponentContext())); xSyncDbusSessionHelper->InstallPackageNames(comphelper::containerToSequence(m_aPackages), OUString()); } - catch (const css::uno::Exception& e) + catch (const css::uno::Exception&) { - SAL_INFO("svl", "trying to install a LibreOffice langpack, caught " << e); + TOOLS_INFO_EXCEPTION("svl", "trying to install a LibreOffice langpack"); } xLangpackInstaller.reset(); } |