loplugin:unuseddefaultparam in svtools

Change-Id: I4e9712bea0cc8cf2d48759738806a584dda8268e

6 files changed, 25 insertions, 34 deletions

diff --git a/svtools/source/misc/embedhlp.cxx b/svtools/source/misc/embedhlp.cxx
index 4efd3d8de961..00b29182ae53 100644
--- a/svtools/source/misc/embedhlp.cxx
+++ b/svtools/source/misc/embedhlp.cxx
@@ -443,7 +443,7 @@ void EmbeddedObjectRef::GetReplacement( bool bUpdate )
     }
 }
 
-const Graphic* EmbeddedObjectRef::GetGraphic( OUString* pMediaType ) const
+const Graphic* EmbeddedObjectRef::GetGraphic() const
 {
     try
     {
@@ -458,8 +458,6 @@ const Graphic* EmbeddedObjectRef::GetGraphic( OUString* pMediaType ) const
         SAL_WARN("svtools.misc", "Something went wrong on getting the graphic: " << ex.Message);
     }
 
-    if ( mpImpl->pGraphic && pMediaType )
-        *pMediaType = mpImpl->aMediaType;
     return mpImpl->pGraphic;
 }
 
diff --git a/svtools/source/misc/imagemgr.cxx b/svtools/source/misc/imagemgr.cxx
index 07b02bbb9ef8..bbc70f48d3bc 100644
--- a/svtools/source/misc/imagemgr.cxx
+++ b/svtools/source/misc/imagemgr.cxx
@@ -595,11 +595,11 @@ Image SvFileInformationManager::GetImage( const INetURLObject& rObject, bool bBi
     return GetImageFromList_Impl( nImage, bBig );
 }
 
-Image SvFileInformationManager::GetFileImage( const INetURLObject& rObject, bool bBig )
+Image SvFileInformationManager::GetFileImage( const INetURLObject& rObject )
 {
     sal_Int16 nImage = GetImageId_Impl( rObject, false );
     DBG_ASSERT( nImage, "invalid ImageId" );
-    return GetImageFromList_Impl( nImage, bBig );
+    return GetImageFromList_Impl( nImage, false/*bBig*/ );
 }
 
 Image SvFileInformationManager::GetImageNoDefault( const INetURLObject& rObject, bool bBig )
@@ -613,7 +613,7 @@ Image SvFileInformationManager::GetImageNoDefault( const INetURLObject& rObject,
     return GetImageFromList_Impl( nImage, bBig );
 }
 
-Image SvFileInformationManager::GetFolderImage( const svtools::VolumeInfo& rInfo, bool bBig )
+Image SvFileInformationManager::GetFolderImage( const svtools::VolumeInfo& rInfo )
 {
     sal_uInt16 nImage = IMG_FOLDER;
     DBG_ASSERT( nImage, "invalid ImageId" );
@@ -627,7 +627,7 @@ Image SvFileInformationManager::GetFolderImage( const svtools::VolumeInfo& rInfo
     else if ( rInfo.m_bIsVolume )
         nImage = IMG_FIXEDDEV;
 
-    return GetImageFromList_Impl( nImage, bBig );
+    return GetImageFromList_Impl( nImage, false/*bBig*/ );
 }
 
 OUString SvFileInformationManager::GetDescription( const INetURLObject& rObject )
diff --git a/svtools/source/misc/templatefoldercache.cxx b/svtools/source/misc/templatefoldercache.cxx
index d8d0ea386ab5..72c7bcbfb380 100644
--- a/svtools/source/misc/templatefoldercache.cxx
+++ b/svtools/source/misc/templatefoldercache.cxx
@@ -812,15 +812,15 @@ namespace svt
     }
 
 
-    bool TemplateFolderCache::needsUpdate( bool _bForceCheck )
+    bool TemplateFolderCache::needsUpdate()
     {
-        return m_pImpl->needsUpdate( _bForceCheck );
+        return m_pImpl->needsUpdate( false/*_bForceCheck*/ );
     }
 
 
-    void TemplateFolderCache::storeState( bool _bForceRetrieval )
+    void TemplateFolderCache::storeState()
     {
-        m_pImpl->storeState( _bForceRetrieval );
+        m_pImpl->storeState( false/*_bForceRetrieval*/ );
     }
 
 
diff --git a/svtools/source/misc/transfer.cxx b/svtools/source/misc/transfer.cxx
index d4761afd9672..81dd5dc34ee0 100644
--- a/svtools/source/misc/transfer.cxx
+++ b/svtools/source/misc/transfer.cxx
@@ -2177,8 +2177,7 @@ TransferableDataHelper TransferableDataHelper::CreateFromSelection( vcl::Window*
 
 
 bool TransferableDataHelper::IsEqual( const css::datatransfer::DataFlavor& rInternalFlavor,
-                                      const css::datatransfer::DataFlavor& rRequestFlavor,
-                                      bool )
+                                      const css::datatransfer::DataFlavor& rRequestFlavor )
 {
     Reference< XComponentContext >          xContext( ::comphelper::getProcessComponentContext() );
     bool                                    bRet = false;
diff --git a/svtools/source/misc/transfer2.cxx b/svtools/source/misc/transfer2.cxx
index 444476b4a66b..f1c98bafb8da 100644
--- a/svtools/source/misc/transfer2.cxx
+++ b/svtools/source/misc/transfer2.cxx
@@ -525,11 +525,11 @@ bool TransferDataContainer::HasAnyData() const
 
 void TransferDataContainer::StartDrag(
         vcl::Window* pWindow, sal_Int8 nDragSourceActions,
-        const Link<sal_Int8,void>& rLnk, sal_Int32 nDragPointer, sal_Int32 nDragImage )
+        const Link<sal_Int8,void>& rLnk, sal_Int32 nDragPointer )
 {
     pImpl->aFinshedLnk = rLnk;
     TransferableHelper::StartDrag( pWindow, nDragSourceActions,
-                                    nDragPointer, nDragImage );
+                                    nDragPointer );
 }
 
 
diff --git a/svtools/source/misc/unitconv.cxx b/svtools/source/misc/unitconv.cxx
index dd13dad23701..e710e8d254f5 100644
--- a/svtools/source/misc/unitconv.cxx
+++ b/svtools/source/misc/unitconv.cxx
@@ -79,26 +79,23 @@ void SetFieldUnit( MetricField& rField, FieldUnit eUnit, bool bAll )
 }
 
 
-void SetFieldUnit( MetricBox& rBox, FieldUnit eUnit, bool bAll )
+void SetFieldUnit( MetricBox& rBox, FieldUnit eUnit )
 {
     sal_Int64 nMin = rBox.Denormalize( rBox.GetMin( FUNIT_TWIP ) );
     sal_Int64 nMax = rBox.Denormalize( rBox.GetMax( FUNIT_TWIP ) );
 
-    if ( !bAll )
+    switch ( eUnit )
     {
-        switch ( eUnit )
-        {
-            case FUNIT_M:
-            case FUNIT_KM:
-                eUnit = FUNIT_CM;
-                break;
+        case FUNIT_M:
+        case FUNIT_KM:
+            eUnit = FUNIT_CM;
+            break;
 
-            case FUNIT_FOOT:
-            case FUNIT_MILE:
-                eUnit = FUNIT_INCH;
-                break;
-            default: ;//prevent warning
-        }
+        case FUNIT_FOOT:
+        case FUNIT_MILE:
+            eUnit = FUNIT_INCH;
+            break;
+        default: ;//prevent warning
     }
     rBox.SetUnit( eUnit );
 
@@ -107,11 +104,8 @@ void SetFieldUnit( MetricBox& rBox, FieldUnit eUnit, bool bAll )
     else
         rBox.SetDecimalDigits( 2 );
 
-    if ( !bAll )
-    {
-        rBox.SetMin( rBox.Normalize( nMin ), FUNIT_TWIP );
-        rBox.SetMax( rBox.Normalize( nMax ), FUNIT_TWIP );
-    }
+    rBox.SetMin( rBox.Normalize( nMin ), FUNIT_TWIP );
+    rBox.SetMax( rBox.Normalize( nMax ), FUNIT_TWIP );
 }