diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:09:01 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:19:22 +0200 |
commit | 91dd2db17bd6cb9b357d1d69b187174e31eabef0 (patch) | |
tree | d634de3a1a6820904b5699c2136b79b1a5a807c7 /svtools/source/table | |
parent | 6f8ea7e89ea190b9462c945d55a3ad8777b2f3ef (diff) |
loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
Diffstat (limited to 'svtools/source/table')
-rw-r--r-- | svtools/source/table/cellvalueconversion.cxx | 12 | ||||
-rw-r--r-- | svtools/source/table/mousefunction.hxx | 2 | ||||
-rw-r--r-- | svtools/source/table/tablecontrol_impl.hxx | 4 | ||||
-rw-r--r-- | svtools/source/table/tabledatawindow.hxx | 2 |
4 files changed, 10 insertions, 10 deletions
diff --git a/svtools/source/table/cellvalueconversion.cxx b/svtools/source/table/cellvalueconversion.cxx index ee9fc710cc88..db62a069b28e 100644 --- a/svtools/source/table/cellvalueconversion.cxx +++ b/svtools/source/table/cellvalueconversion.cxx @@ -153,7 +153,7 @@ namespace svt return returnValue; } - virtual ~DoubleNormalization() { } + virtual ~DoubleNormalization() override { } }; @@ -167,7 +167,7 @@ namespace svt { } - virtual ~IntegerNormalization() {} + virtual ~IntegerNormalization() override {} virtual double convertToDouble( Any const & i_value ) const override { @@ -188,7 +188,7 @@ namespace svt { } - virtual ~BooleanNormalization() {} + virtual ~BooleanNormalization() override {} virtual double convertToDouble( Any const & i_value ) const override { @@ -209,7 +209,7 @@ namespace svt { } - virtual ~DateTimeNormalization() {} + virtual ~DateTimeNormalization() override {} virtual double convertToDouble( Any const & i_value ) const override { @@ -243,7 +243,7 @@ namespace svt { } - virtual ~DateNormalization() {} + virtual ~DateNormalization() override {} virtual double convertToDouble( Any const & i_value ) const override { @@ -273,7 +273,7 @@ namespace svt { } - virtual ~TimeNormalization() {} + virtual ~TimeNormalization() override {} virtual double convertToDouble( Any const & i_value ) const override { diff --git a/svtools/source/table/mousefunction.hxx b/svtools/source/table/mousefunction.hxx index 4ecca061fa18..7136c11c8aac 100644 --- a/svtools/source/table/mousefunction.hxx +++ b/svtools/source/table/mousefunction.hxx @@ -60,7 +60,7 @@ namespace svt { namespace table virtual FunctionResult handleMouseUp( ITableControl& i_tableControl, MouseEvent const & i_event ) = 0; protected: - virtual ~MouseFunction() { } + virtual ~MouseFunction() override { } }; diff --git a/svtools/source/table/tablecontrol_impl.hxx b/svtools/source/table/tablecontrol_impl.hxx index 889f188721df..02b36268ea4b 100644 --- a/svtools/source/table/tablecontrol_impl.hxx +++ b/svtools/source/table/tablecontrol_impl.hxx @@ -151,7 +151,7 @@ namespace svt { namespace table public: explicit TableControl_Impl( TableControl& _rAntiImpl ); - virtual ~TableControl_Impl(); + virtual ~TableControl_Impl() override; /** to be called when the anti-impl instance has been resized */ @@ -461,7 +461,7 @@ namespace svt { namespace table public: explicit TableFunctionSet(TableControl_Impl* _pTableControl); - virtual ~TableFunctionSet(); + virtual ~TableFunctionSet() override; virtual void BeginDrag() override; virtual void CreateAnchor() override; diff --git a/svtools/source/table/tabledatawindow.hxx b/svtools/source/table/tabledatawindow.hxx index b50a5de027e9..ee1300e5e438 100644 --- a/svtools/source/table/tabledatawindow.hxx +++ b/svtools/source/table/tabledatawindow.hxx @@ -41,7 +41,7 @@ namespace svt { namespace table public: explicit TableDataWindow( TableControl_Impl& _rTableControl ); - virtual ~TableDataWindow(); + virtual ~TableDataWindow() override; virtual void dispose() override; inline void SetSelectHdl(const Link<LinkParamNone*,void>& rLink) |