diff options
author | Eike Rathke <erack@redhat.com> | 2016-09-22 22:20:48 +0200 |
---|---|---|
committer | Eike Rathke <erack@redhat.com> | 2016-09-23 15:14:03 +0000 |
commit | 7d8196ea2f4ec3634dbad7367345e62c4ea9893d (patch) | |
tree | 4550d4ccc4205ae5ca9f134d29927b202e10fb70 /svtools/source | |
parent | 751689283c9f3010f7978b6576b25ffc579202ef (diff) |
perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related
There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.
To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.
For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.
Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Diffstat (limited to 'svtools/source')
-rw-r--r-- | svtools/source/config/accessibilityoptions.cxx | 10 | ||||
-rw-r--r-- | svtools/source/config/colorcfg.cxx | 1 | ||||
-rw-r--r-- | svtools/source/config/extcolorcfg.cxx | 8 |
3 files changed, 7 insertions, 12 deletions
diff --git a/svtools/source/config/accessibilityoptions.cxx b/svtools/source/config/accessibilityoptions.cxx index 1e7267835d60..0e874b0097fc 100644 --- a/svtools/source/config/accessibilityoptions.cxx +++ b/svtools/source/config/accessibilityoptions.cxx @@ -28,7 +28,7 @@ #include <comphelper/configurationhelper.hxx> #include <comphelper/processfactory.hxx> -#include <svl/smplhint.hxx> +#include <svl/hint.hxx> #include <svtools/colorcfg.hxx> @@ -407,12 +407,8 @@ SvtAccessibilityOptions::~SvtAccessibilityOptions() void SvtAccessibilityOptions::Notify( SfxBroadcaster&, const SfxHint& rHint ) { NotifyListeners(0); - const SfxSimpleHint* pSfxSimpleHint = dynamic_cast<const SfxSimpleHint*>(&rHint); - if ( pSfxSimpleHint ) - { - if ( pSfxSimpleHint->GetId() == SFX_HINT_ACCESSIBILITY_CHANGED ) - SetVCLSettings(); - } + if ( rHint.GetId() == SFX_HINT_ACCESSIBILITY_CHANGED ) + SetVCLSettings(); } diff --git a/svtools/source/config/colorcfg.cxx b/svtools/source/config/colorcfg.cxx index 4af1d69ecf86..1f8eb4361311 100644 --- a/svtools/source/config/colorcfg.cxx +++ b/svtools/source/config/colorcfg.cxx @@ -30,7 +30,6 @@ #include <unotools/configpaths.hxx> #include <com/sun/star/uno/Sequence.h> #include <svl/poolitem.hxx> -#include <svl/smplhint.hxx> #include <osl/mutex.hxx> #include "itemholder2.hxx" diff --git a/svtools/source/config/extcolorcfg.cxx b/svtools/source/config/extcolorcfg.cxx index 18c1807aa862..f800ff6f3584 100644 --- a/svtools/source/config/extcolorcfg.cxx +++ b/svtools/source/config/extcolorcfg.cxx @@ -31,7 +31,7 @@ #include <unotools/configpaths.hxx> #include <com/sun/star/uno/Sequence.h> #include <svl/poolitem.hxx> -#include <svl/smplhint.hxx> +#include <svl/hint.hxx> #include <osl/mutex.hxx> #include <vcl/svapp.hxx> @@ -402,7 +402,7 @@ void ExtendedColorConfig_Impl::Notify( const uno::Sequence<OUString>& /*rProp m_bBroadcastWhenUnlocked = true; } else - Broadcast(SfxSimpleHint(SFX_HINT_COLORS_CHANGED)); + Broadcast(SfxHint(SFX_HINT_COLORS_CHANGED)); } void ExtendedColorConfig_Impl::ImplCommit() @@ -501,7 +501,7 @@ void ExtendedColorConfig_Impl::SettingsChanged() { SolarMutexGuard aVclGuard; - Broadcast( SfxSimpleHint( SFX_HINT_COLORS_CHANGED ) ); + Broadcast( SfxHint( SFX_HINT_COLORS_CHANGED ) ); } void ExtendedColorConfig_Impl::LockBroadcast() @@ -519,7 +519,7 @@ void ExtendedColorConfig_Impl::UnlockBroadcast() if ( ExtendedColorConfig_Impl::IsEnableBroadcast() ) { m_bBroadcastWhenUnlocked = false; - ExtendedColorConfig::m_pImpl->Broadcast(SfxSimpleHint(SFX_HINT_COLORS_CHANGED)); + ExtendedColorConfig::m_pImpl->Broadcast(SfxHint(SFX_HINT_COLORS_CHANGED)); } } } |